Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converting dbc <=> xls <=> dbc #5

Closed
nexulm opened this issue Nov 9, 2015 · 4 comments
Closed

converting dbc <=> xls <=> dbc #5

nexulm opened this issue Nov 9, 2015 · 4 comments

Comments

@nexulm
Copy link

nexulm commented Nov 9, 2015

converting a dbc to xls and vice versa back to dbc again without changing anything I get this fault:

Traceback (most recent call last):
File "convert.py", line 65, in
dbs["default"] = im.importXls(infile)
File "/cygdrive/v/CANtools/canmatrix/library/importxls.py", line 217, in importXls
newSig._factor = float(factor)
ValueError: could not convert string to float: degree

ebroecker added a commit that referenced this issue Nov 9, 2015
@ebroecker
Copy link
Owner

found a small bug, please try xls->dbc again...

@nexulm
Copy link
Author

nexulm commented Nov 9, 2015

OK, it's working now (again)!
I'm currently confused that the output dbc file has "default_" as prefix (=> "default_output.dbc").

@ebroecker
Copy link
Owner

OK, thanks for testing and finding bugs :-)

yes the "default" is confusing.
This is because .arxml can contain multiple can-configurations and the importers all use the same api.

ebroecker added a commit that referenced this issue Nov 9, 2015
@ebroecker
Copy link
Owner

fixed 'default'-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants