-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a third item to multiattack breaks CR calculation #32
Comments
hey! thanks for giving the tool a try. What's happening there is a bit of order of operations concerns:
This requires a bit of explanation. One of the weird things in CR calculation is that the defensive CR's effective HP multipliers change based on the expected CR of the monster. This is a bit of a problem for an automatic estimator, as I couldn't really assume that someone would pick an expected CR first, so I made the decision to base the defensive CR's calculations on the offensive CR (which does not require adjustments to compute). A side effect of this decision is the edge case you've found here. At CR 17+, the effective HP multiplier for resistances is So the tl;dr is that it's not really a bug but an edge case in the creation of an automatic CR calculator. I'd be interested to know what you'd like the behavior to be there (can add a toggle to use the manually-selected CR from the stat block for defensive?). As for the second part, I'll take a look at the lair actions I might've put them in the actions stack by accident. They're supposed to be handled like traits (apply every round on top of a selected action). |
I think adding a toggle might be best, with a suggestion to use it when creating creatures CR 15-17+ |
This issue has been addressed in version 2, see #69 for a preview |
I have no experience with JS, or I'd try to run this bug down myself.
When I add the third item to a multiattack group, the CR calculation suddenly stops including Resistances in the defensive CR calculation, resulting in an Estimated CR of 12 (17 Offensive, 8 Defensive) instead of 15/16. This doesn't seem to make any sense, given that an attack should have no effect on the monster's Resistances, let alone completely cancelling them out.
Below is the dump of the .5emm.json. Github isn't letting me upload even txt files for some reason
P.S.: I think when it calculates Lair Actions in the CR, it is incorrectly replacing standard actions or multiattacks with the lair actions, rather than adding them on top of the normal calculation like (I think) it should. Lair actions should be totally independent of the action economy of the monster that gets them, unless I'm reading the manuals wrong.
The text was updated successfully, but these errors were encountered: