Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata not allowed on style #15

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Metadata not allowed on style #15

merged 1 commit into from
Aug 8, 2018

Conversation

andreastai
Copy link
Collaborator

Metadata not allowed on style
3a882d6 
- TTML does not allow a tt:metadata child under tt:style.

- This closes #9.
nigelmegitt
nigelmegitt approved these changes Jul 25, 2018
View reviewed changes
Copy link
Collaborator

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (manually) and works. Looks good to me.

@andreastai
Copy link
Collaborator Author

Thanks @nigelmegitt. I will merge it after the 10 working days review period have passed.

@andreastai
Copy link
Collaborator Author

As the PR is open for more than 10 working days, it is merged.

@andreastai andreastai merged commit 4279943 into drafting Aug 8, 2018
@andreastai andreastai mentioned this pull request Aug 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreastai @nigelmegitt