Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEPT-1546: Use an Attributes container for handling template attributes. #50

Merged
merged 2 commits into from
Oct 23, 2017
Merged

NEPT-1546: Use an Attributes container for handling template attributes. #50

merged 2 commits into from
Oct 23, 2017

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Sep 1, 2017

No description provided.

@voidtek
Copy link
Member

voidtek commented Sep 1, 2017

I like this improvement ... 👍

@drupol
Copy link
Contributor Author

drupol commented Sep 1, 2017

We need to fix the class, the tests, and the process hooks first.

@voidtek
Copy link
Member

voidtek commented Sep 1, 2017

of course .... :)

@drupol drupol force-pushed the attributes-as-objects branch 8 times, most recently from 7e99eac to 94d1222 Compare September 6, 2017 08:17
@drupol drupol changed the title Experimental: allows the use of an Attributes object. Use an Attributes container for handling template attributes. Sep 6, 2017
@drupol drupol force-pushed the attributes-as-objects branch 3 times, most recently from 857c687 to 42e6f92 Compare September 13, 2017 10:07
@drupol drupol mentioned this pull request Sep 18, 2017
Closed
@drupol drupol changed the title Use an Attributes container for handling template attributes. NEPT-1546: Use an Attributes container for handling template attributes. Sep 27, 2017
@drupol drupol force-pushed the attributes-as-objects branch 3 times, most recently from a7ac844 to 4524018 Compare September 28, 2017 09:23
@voidtek
Copy link
Member

voidtek commented Oct 3, 2017

👍

@ku-enza
Copy link
Contributor

ku-enza commented Oct 17, 2017

It's a big pull request, nice work! 👍

ku-enza
ku-enza approved these changes Oct 18, 2017
View reviewed changes
Copy link
Contributor

@ku-enza ku-enza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add so far. 👍

@drupol drupol merged commit 60ac562 into 7.x-1.x Oct 23, 2017
@drupol drupol deleted the attributes-as-objects branch October 23, 2017 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ku-enza ku-enza ku-enza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drupol @voidtek @ku-enza