feat(footers): Adding EC logo to all the footers - FRONT-3224 #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papegaill
suggested changes
Oct 8, 2021
| @@ -17,6 +17,18 @@ exports[`Footer Core EC default renders correctly 1`] = ` | |||
| <div | |||
| class="ecl-footer-core__section" | |||
| > | |||
| <a | |||
There was a problem hiding this comment.
Strange focus state actually on the logo:
already better by having display:block to the href
I think it would be better to set the bottom margin on the parent href instead of the logo imgso the focus will be better around the logo only. as made on standardised?
There was a problem hiding this comment.
You're right, the element was inline and that's why the margin was applied to the image, now this behaves as the others.
...entations/twig/components/footer-standardised/__snapshots__/footer-standardised.test.js.snap
Show resolved
Hide resolved
…pa-component-library into front-3224-ec-logo-footer
papegaill
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.