feat(spinner): Adding component - FRONT-3223 #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
requested changes
Nov 16, 2021
| - "size" (string) options: | ||
| [ small, medium, large ] | ||
| - "text" (string) (default: '') | ||
| - "visible" (boolean) (default false) |
There was a problem hiding this comment.
missing "centered" and "overlay" parameters
| options: [ small, medium, large ] | ||
| - **"text"** (string) (default: '') | ||
| - **"visible"** (boolean) (default: false) | ||
| - **"centered"** (boolean) (default: true)) |
There was a problem hiding this comment.
missing "overlay" parameter
| {% endif %} | ||
|
|
||
| {% if _visible %} | ||
| {% set _css_classes = _css_classes ~ ' ecl-spinner--active' %} |
There was a problem hiding this comment.
as the parameter is called "visible", maybe we could use the same name for the class (".ecl-spinner--visible"). Same for the overlay
| category: 'Content', | ||
| }, | ||
| }, | ||
| variant: { |
There was a problem hiding this comment.
when selecting negative spinner on storybook (in the controls), we should apply a background (similar to what has been done for the links), otherwise it is not visible (in primary story)
Or we just don't show this control
| } | ||
| } | ||
| // stylelint-disable-next-line plugin/selector-bem-pattern | ||
| .path { |
There was a problem hiding this comment.
can't we apply the namespace/bem pattern for this css class too?
emeryro
previously approved these changes
Nov 16, 2021
…y into front-3223-spinner
…onent-library into front-3223-spinner
emeryro
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a twig implementation of a "spinner" component.
It is not clear how to make this usable in an application,
UPDATE:
After talking with Francesco it seems that this will ony be used as a example markup that needs to be copied into a drupal function, so not using any twig template.
Therefore the current approach seems potentially correct.