Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(news-ticker): Fix showcase iframe resize issue - FRONT-3425 #2271

Merged
merged 5 commits into from
Dec 7, 2021
Merged

fix(news-ticker): Fix showcase iframe resize issue - FRONT-3425 #2271

merged 5 commits into from
Dec 7, 2021

Conversation

papegaill
Copy link
Contributor

@papegaill papegaill commented Nov 30, 2021 •
edited
Loading

The heightCalculationMethod option for the showcase iframes is causing the issues.
Using max value instead of lowestElement solve the issues.
see: http://davidjbradshaw.github.io/iframe-resizer/

@papegaill papegaill requested a review from a team November 30, 2021 13:15
@papegaill papegaill changed the title Fix showcase iframe resize issue chore: Fix showcase iframe resize issue - FRONT-3425 Nov 30, 2021
@papegaill papegaill changed the title chore: Fix showcase iframe resize issue - FRONT-3425 fix(news-ticker): Fix showcase iframe resize issue - FRONT-3425 Nov 30, 2021
@github-actions
Copy link

github-actions bot commented Nov 30, 2021 •
edited
Loading

🚀 Deployed on https://ecl-preview-2271--europa-component-library.netlify.app

@emeryro emeryro self-assigned this Dec 6, 2021
emeryro
emeryro requested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this update indeed fixes the news ticker issue. But it introduced a new bug on the site-header/menu showcase
menu
It is also slightly visible when closing the multi select

@emeryro emeryro removed their assignment Dec 6, 2021
@papegaill
Copy link
Contributor Author

this update indeed fixes the news ticker issue. But it introduced a new bug on the site-header/menu showcase menu It is also slightly visible when closing the multi select

Thank you for spotting this!
I'm now applying the max heightCalulationMethod only to the news-ticker showcase iframe.

@emeryro emeryro merged commit cc8398e into v3-dev Dec 7, 2021
@emeryro emeryro deleted the fix/FRONT-3425 branch December 7, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emeryro emeryro emeryro approved these changes

Assignees
No one assigned
Labels
tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@papegaill @emeryro