Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rtl): right-to-left batch 2 - FRONT-3566 #2359

Merged
merged 4 commits into from
Mar 18, 2022
Merged

feat(rtl): right-to-left batch 2 - FRONT-3566 #2359

merged 4 commits into from
Mar 18, 2022

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Mar 16, 2022 •
edited
Loading

  • carousel
  • featured-item
  • gallery
  • hero-banner
  • icon
  • media-container
  • page-banner
  • social-media-follow
  • social-media-share

Notes:

  • there are a few elements that will be handled in another batch (for instance links and button). So display may not be fully operational yet (would need a final review when all batch are done)
  • carousel has to be be fixed in js, at a later stage

@emeryro emeryro self-assigned this Mar 16, 2022
@github-actions
Copy link

github-actions bot commented Mar 16, 2022 •
edited
Loading

🚀 Deployed on https://ecl-preview-2359--europa-component-library.netlify.app

@emeryro emeryro removed their assignment Mar 16, 2022
@emeryro emeryro marked this pull request as ready for review March 16, 2022 12:52
@emeryro emeryro requested a review from a team March 16, 2022 12:52
papegaill
papegaill suggested changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@papegaill papegaill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see a spacing issue on the social links
Screenshot 2022-03-17 at 11 41 20

@emeryro
Copy link
Contributor Author

emeryro commented Mar 17, 2022

I merged with the first batch containing the link, it should be good for social share now

papegaill
papegaill approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@papegaill papegaill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed an issue with EU gallery modal background, support ticket created as a follluw-up

@papegaill papegaill merged commit 1019c6b into v3-dev Mar 18, 2022
@papegaill papegaill deleted the FRONT-3566-rtl-batch2 branch March 18, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papegaill papegaill papegaill approved these changes

Assignees
No one assigned
Labels
tag: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emeryro @papegaill