Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rtl): batch 4 - FRONT-3568 #2385

Merged
merged 9 commits into from
Apr 12, 2022
Merged

feat(rtl): batch 4 - FRONT-3568 #2385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
760e146
update components
emeryro Apr 6, 2022
3bce9a6
Merge branch 'v3-dev' into FRONT-3568-rtl-batch4
emeryro Apr 6, 2022
ff1d1a6
update components
emeryro Apr 6, 2022
fb5a5b7
Merge branch 'v3-dev' into FRONT-3568-rtl-batch4
emeryro Apr 11, 2022
86ba7e6
update
emeryro Apr 11, 2022
ab9fb0a
udpate tests
emeryro Apr 11, 2022
63e8f22
Merge branch 'v3-dev' into FRONT-3568-rtl-batch4
emeryro Apr 11, 2022
f89047a
fix timeline
emeryro Apr 11, 2022
03195ed
fix timeline
emeryro Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/implementations/twig/components/news-ticker/__snapshots__/news-ticker.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,12 @@ exports[`News ticker Default renders correctly 1`] = `
>
1
</span>
of 6

of
<span
class="ecl-news-ticker__counter--max"
>
6
</span>
</div>
<div
class="ecl-news-ticker__controls"
Expand Down Expand Up @@ -284,8 +288,12 @@ exports[`News ticker Default renders correctly with extra attributes 1`] = `
>
1
</span>
of 6

of
<span
class="ecl-news-ticker__counter--max"
>
6
</span>
</div>
<div
class="ecl-news-ticker__controls"
Expand Down Expand Up @@ -464,8 +472,12 @@ exports[`News ticker Default renders correctly with extra class names 1`] = `
>
1
</span>
of 6

of
<span
class="ecl-news-ticker__counter--max"
>
6
</span>
</div>
<div
class="ecl-news-ticker__controls"
Expand Down
4 changes: 3 additions & 1 deletion src/implementations/twig/components/news-ticker/news-ticker.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@
extra_classes: 'ecl-news-ticker__icon',
} only %}
<div class="ecl-news-ticker__counter">
<span class="ecl-news-ticker__counter--current">1</span> {{ _counter_label }} {{_items|length}}
<span class="ecl-news-ticker__counter--current">1</span>
{{- ' ' -}}{{- _counter_label }}{{- ' ' -}}
<span class="ecl-news-ticker__counter--max">{{_items|length}}</span>
</div>
<div class="ecl-news-ticker__controls">
{% include '@ecl/button/button.html.twig' with {
Expand Down
15 changes: 10 additions & 5 deletions src/implementations/vanilla/components/accordion/accordion-ec.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
font-weight: map.get(theme.$font-weight, 'bold');
padding: 0 map.get(theme.$spacing, 'm');
position: relative;
text-align: left;
text-align: start;
width: 100%;
}

Expand All @@ -60,8 +60,10 @@
display: flex;
flex-grow: 0;
flex-shrink: 0;
margin: map.get(theme.$spacing, 's') map.get(theme.$spacing, 'm')
map.get(theme.$spacing, 's') 0;
margin-bottom: map.get(theme.$spacing, 's');
margin-inline-start: 0;
margin-inline-end: map.get(theme.$spacing, 'm');
margin-top: map.get(theme.$spacing, 's');
}

.ecl-accordion__toggle-label {
Expand All @@ -80,8 +82,11 @@
.ecl-accordion__content {
color: map.get(theme.$color, 'grey');
font: map.get(theme.$font-prolonged, 'm');
margin-left: 0;
padding: map.get(theme.$spacing, 's') map.get(theme.$spacing, 'm');
margin-inline-start: 0;
padding-bottom: map.get(theme.$spacing, 's');
padding-inline-end: map.get(theme.$spacing, 'm');
padding-inline-start: map.get(theme.$spacing, 'm');
padding-top: map.get(theme.$spacing, 's');
}

.no-js .ecl-accordion__content {
Expand Down
28 changes: 14 additions & 14 deletions src/implementations/vanilla/components/accordion/accordion-eu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
&:first-child {
&::before {
background-color: map.get(theme.$color, 'yellow-100');
border-bottom-left-radius: 2px;
border-bottom-right-radius: 2px;
border-end-start-radius: 2px;
border-end-end-radius: 2px;
content: '';
height: 4px;
left: map.get(theme.$spacing, 'l');
Expand All @@ -32,28 +32,28 @@
}

.ecl-accordion__toggle {
border-top-left-radius: 8px;
border-top-right-radius: 8px;
border-start-start-radius: 8px;
border-start-end-radius: 8px;
}
}

&:last-child {
.ecl-accordion__toggle {
border-bottom-color: transparent;
border-bottom-left-radius: 8px;
border-bottom-right-radius: 8px;
border-end-start-radius: 8px;
border-end-end-radius: 8px;

&[aria-expanded='true'] {
border-bottom-color: map.get(theme.$color, 'blue-20');
border-bottom-left-radius: 0;
border-bottom-right-radius: 0;
border-end-start-radius: 0;
border-end-end-radius: 0;
}
}

.ecl-accordion__content {
border-bottom: 0;
border-bottom-left-radius: 8px;
border-bottom-right-radius: 8px;
border-end-start-radius: 8px;
border-end-end-radius: 8px;
overflow: hidden;
}
}
Expand All @@ -73,7 +73,7 @@
font: map.get(theme.$font-prolonged, 'l');
padding: map.get(theme.$spacing, 'l');
position: relative;
text-align: left;
text-align: start;
width: 100%;
}

Expand Down Expand Up @@ -105,7 +105,7 @@
display: flex;
flex-grow: 0;
flex-shrink: 0;
margin-left: map.get(theme.$spacing, 's');
margin-inline-start: map.get(theme.$spacing, 's');
order: 2;
padding: 2px 0;

Expand All @@ -128,10 +128,10 @@

.ecl-accordion__content {
border-bottom: 2px solid map.get(theme.$color, 'blue-20');
border-left: 4px solid map.get(theme.$color, 'blue');
border-inline-start: 4px solid map.get(theme.$color, 'blue');
color: map.get(theme.$color, 'grey-80');
font: map.get(theme.$font-prolonged, 'm');
margin-left: 0;
margin-inline-start: 0;
padding: map.get(theme.$spacing, 'l');
}

Expand Down
2 changes: 1 addition & 1 deletion src/implementations/vanilla/components/accordion/accordion-print.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
font-family: #{map.get(theme.$font-family-print, 'alt')};
font-weight: map.get(theme.$font-weight-print, 'bold');
padding: 0;
text-align: left;
text-align: start;
width: 100%;
}

Expand Down
25 changes: 14 additions & 11 deletions src/implementations/vanilla/components/blockquote/_blockquote.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
@use '@ecl/vanilla-layout-grid/mixins/breakpoints';

$_border-width: null !default;
$_border-radius: null !default;
$_border-radius-top-left: null !default;
$_border-radius-bottom-left: null !default;
$_border-color: null !default;
$_body-font-mobile: null !default;
$_body-font-tablet: null !default;
Expand All @@ -25,11 +26,12 @@ $_text-max-width: 65ch; // Approximately 80 characters with the current font

.ecl-blockquote,
%ecl-blockquote {
border-left: $_border-width solid $_border-color;
border-radius: $_border-radius;
border-inline-start: $_border-width solid $_border-color;
border-start-start-radius: $_border-radius-top-left;
border-end-start-radius: $_border-radius-bottom-left;
margin: 0;
padding-bottom: map.get(theme.$spacing, 's');
padding-left: $_padding-left-mobile;
padding-inline-start: $_padding-left-mobile;
padding-top: map.get(theme.$spacing, 's');
}

Expand Down Expand Up @@ -80,7 +82,7 @@ $_text-max-width: 65ch; // Approximately 80 characters with the current font
.ecl-blockquote,
%ecl-blockquote {
padding-bottom: map.get(theme.$spacing, 'm');
padding-left: map.get(theme.$spacing, 'l');
padding-inline-start: map.get(theme.$spacing, 'l');
padding-top: map.get(theme.$spacing, 'm');
}

Expand All @@ -106,20 +108,21 @@ $_text-max-width: 65ch; // Approximately 80 characters with the current font
@include breakpoints.up('l') {
.ecl-blockquote,
%ecl-blockquote {
border-left: 0;
border-inline-start: 0;
display: flex;
flex-direction: row-reverse;
justify-content: left;
justify-content: start;
padding: 0;
}

.ecl-blockquote__body,
%ecl-blockquote {
border-left: $_border-width solid $_border-color;
border-radius: $_border-radius;
border-inline-start: $_border-width solid $_border-color;
border-start-start-radius: $_border-radius-top-left;
border-end-start-radius: $_border-radius-bottom-left;
display: inline-block;
padding-bottom: map.get(theme.$spacing, 'm');
padding-left: map.get(theme.$spacing, 'l');
padding-inline-start: map.get(theme.$spacing, 'l');
padding-top: map.get(theme.$spacing, 'm');
}

Expand All @@ -142,7 +145,7 @@ $_text-max-width: 65ch; // Approximately 80 characters with the current font

.ecl-blockquote__image,
%ecl-blockquote__image {
margin-right: map.get(theme.$spacing, 'l');
margin-inline-end: map.get(theme.$spacing, 'l');
margin-top: 0;
}
}
3 changes: 2 additions & 1 deletion src/implementations/vanilla/components/blockquote/blockquote-ec.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
@use 'blockquote' with (
$_border-width: 10px,
$_border-color: map.get(theme.$color, 'yellow-100'),
$_border-radius: 0,
$_border-radius-top-left: 0,
$_border-radius-bottom-left: 0,
$_padding-left-mobile: map.get(theme.$spacing, 'l'),
$_body-font-mobile: map.get(theme.$font-prolonged, 'm'),
$_body-font-tablet: map.get(theme.$font-prolonged, 'm'),
Expand Down
3 changes: 2 additions & 1 deletion src/implementations/vanilla/components/blockquote/blockquote-eu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
@use 'blockquote' with (
$_border-width: 8px,
$_border-color: map.get(theme.$color, 'blue-100'),
$_border-radius: 4px 0 0 4px,
$_border-radius-top-left: 4px,
$_border-radius-bottom-left: 4px,
$_padding-left-mobile: map.get(theme.$spacing, 'm'),
$_body-font-mobile: map.get(theme.$font-prolonged, 'l'),
$_body-font-tablet: map.get(theme.$font, '2xl'),
Expand Down
10 changes: 5 additions & 5 deletions src/implementations/vanilla/components/category-filter/_category-filter.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,25 +51,25 @@ $_outline-width: 3px !default;

&.ecl-category-filter__item--level-2 {
justify-content: initial;
padding-left: map.get(theme.$spacing, 'xl');
padding-inline-start: map.get(theme.$spacing, 'xl');

&.ecl-category-filter__item--has-children {
padding-left: map.get(theme.$spacing, 'xs');
padding-inline-start: map.get(theme.$spacing, 'xs');
}
}

&.ecl-category-filter__item--level-3 {
justify-content: initial;
padding-left: map.get(theme.$spacing, '3xl');
padding-inline-start: map.get(theme.$spacing, '3xl');

&.ecl-category-filter__item--has-children {
padding-left: map.get(theme.$spacing, 'l');
padding-inline-start: map.get(theme.$spacing, 'l');
}
}

&.ecl-category-filter__item--level-4 {
justify-content: initial;
padding-left: map.get(theme.$spacing, '4xl');
padding-inline-start: map.get(theme.$spacing, '4xl');
}
}

Expand Down
16 changes: 8 additions & 8 deletions src/implementations/vanilla/components/fact-figures/_fact-figures.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@ $_view-all-padding-vertical: null !default;

.ecl-fact-figures__items {
padding-bottom: map.get(theme.$spacing, 'xl');
padding-left: $_items-padding-horizontal-mobile;
padding-right: $_items-padding-horizontal-mobile;
padding-inline-start: $_items-padding-horizontal-mobile;
padding-inline-end: $_items-padding-horizontal-mobile;
padding-top: 0;
}

.ecl-fact-figures__item {
box-sizing: border-box;
font: map.get(theme.$font, 'm');
padding-left: map.get(theme.$spacing, 'm');
padding-right: map.get(theme.$spacing, 'm');
padding-inline-start: map.get(theme.$spacing, 'm');
padding-inline-end: map.get(theme.$spacing, 'm');
padding-top: map.get(theme.$spacing, 'xl');
}

Expand Down Expand Up @@ -77,8 +77,8 @@ $_view-all-padding-vertical: null !default;
.ecl-fact-figures__view-all {
border-top: 1px solid $_view-all-border-color;
font: map.get(theme.$font, 'm');
margin-left: $_view-all-margin-horizontal;
margin-right: $_view-all-margin-horizontal;
margin-inline-start: $_view-all-margin-horizontal;
margin-inline-end: $_view-all-margin-horizontal;
padding-bottom: $_view-all-padding-vertical;
padding-top: $_view-all-padding-vertical;
}
Expand All @@ -88,8 +88,8 @@ $_view-all-padding-vertical: null !default;
.ecl-fact-figures__items {
display: flex;
flex-wrap: wrap;
padding-left: $_items-padding-horizontal-desktop;
padding-right: $_items-padding-horizontal-desktop;
padding-inline-start: $_items-padding-horizontal-desktop;
padding-inline-end: $_items-padding-horizontal-desktop;
}

.ecl-fact-figures__item {
Expand Down
2 changes: 1 addition & 1 deletion src/implementations/vanilla/components/language-list/_language-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ $_padding-list-splash-desktop: null !default;
}

.ecl-language-list__title-icon {
margin-right: map.get(theme.$spacing, 'm');
margin-inline-end: map.get(theme.$spacing, 'm');
}

/* stylelint-disable-next-line order/order */
Expand Down
20 changes: 13 additions & 7 deletions src/implementations/vanilla/components/message/_message-print.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ $_background-error: none !default;
$_background-info: none !default;
$_background-success: none !default;
$_background-warning: none !default;
$_border-radius: none !default;
$_border-radius-top-left: none !default;
$_border-radius-bottom-left: none !default;
$_border-width: none !default;
$_description-color: none !default;
$_icon-spacing: none !default;
Expand All @@ -23,20 +24,25 @@ $_title-font: none !default;
$_title-spacing: none !default;

.ecl-message {
border-radius: $_border-radius;
border-bottom-width: map.get($_border-width, 'bottom');
border-end-start-radius: $_border-radius-bottom-left;
border-inline-end-width: map.get($_border-width, 'right');
border-inline-start-width: map.get($_border-width, 'left');
border-start-start-radius: $_border-radius-top-left;
border-style: solid;
border-width: $_border-width;
border-top-width: map.get($_border-width, 'top');
display: inline-flex;
margin: 0;
padding: map.get(theme.$spacing-print, 'l')
map.get(theme.$spacing-print, 'xs') map.get(theme.$spacing-print, 'l')
map.get(theme.$spacing-print, 'l');
padding-bottom: map.get(theme.$spacing-print, 'l');
padding-inline-end: map.get(theme.$spacing-print, 'xs');
padding-inline-start: map.get(theme.$spacing-print, 'l');
padding-top: map.get(theme.$spacing-print, 'l');
}

.ecl-message__icon {
display: block;
flex-shrink: 0;
margin-right: $_icon-spacing;
margin-inline-end: $_icon-spacing;
}

.ecl-message__close {
Expand Down
Loading