feat(datepicker): Adapt JS for RTL support - FRONT-3595 #2396
Conversation
| @@ -47,6 +57,7 @@ | |||
| <script> | |||
| // https://github.com/storybookjs/storybook/issues/6113#issuecomment-473965255 | |||
| function runOnPageChange() { | |||
| ECL.autoInit().destroy(); | |||
There was a problem hiding this comment.
Do we really need to destroy everything on each click on in a different story..? I don't necessarily see the need for this, but i might not consider something..
There was a problem hiding this comment.
Yes first of all to lighten the global ECL.components array which grows with each component instantiation. And also because I noticed that by switching rtl and navigate between the stories, if the destroy is not done it creates problems..
| @@ -1,4 +1,4 @@ | |||
| /* eslint-disable no-console */ | |||
| /* eslint-disable no-plusplus */ | |||
There was a problem hiding this comment.
Why adding an exclusion and not changing the syntax to prevent the error..? What was wrong with the previous forEach, by the way..?
There was a problem hiding this comment.
The previous foreach was wrong, removing elements from the array during the loop misleads the final result.
it's therefore necessary to loop backwards to avoid any breaking..
No description provided.