Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(news-ticker): Fix accessibility issues - FRONT-3634 #2534

Merged
merged 4 commits into from
May 30, 2022

Conversation

papegaill
Copy link
Contributor

@papegaill papegaill commented May 19, 2022

  • The newsticker is not fully keyboard operable: the buttons for the next and previous items do not receive keyboard focus. Make sure the buttons can be reached with the TAB key and activated with the ENTER key (remove the tabindex attribute).
    • already done since 3.3.0
  • The buttons for the next and previous items are not labelled. Provide text inside the button or use aria-label.
    • already done since 3.3.0
  • The button to start and pause the ticker is not labelled. Provide text inside the button or use aria-label.
    • already done since 3.3.0
  • The items inside the ticker are focusable but hidden from screen readers with aria-hidden. Remove the aria-hidden
    • fixed in this PR
  • Best practice recommendations: Pause the ticker automatically when the keyboard focus is on a news item in the ticker. Users who need a bit more time to complete actions will very much appreciate this.
    • added in this PR

NB: I'm also fixing following styles issues (since 3.3.0)

  • margin issue with button icons
  • alignment of the counter on mobile version

@github-actions
Copy link

github-actions bot commented May 19, 2022

@papegaill papegaill changed the base branch from v3-dev to v3.4.0-dev May 25, 2022 12:43
@emeryro emeryro self-assigned this May 30, 2022
@emeryro emeryro merged commit ac82e84 into v3.4.0-dev May 30, 2022
@emeryro emeryro deleted the fix/FRONT-3634 branch May 30, 2022 10:59
@emeryro emeryro removed their assignment May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants