Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): Add invalid icons for EC and fix them for EU - FRONT-3651 #2554

Merged
merged 7 commits into from
Jun 13, 2022

Conversation

papegaill
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented May 31, 2022

extra_classes: 'ecl-feedback-message__icon',
} only %}
{% endif %}
{{- invalid_text -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should output a block here, same as what is done on the text field for instance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, but initially I took this from the date picker where the parameter is not a block, should we create a ticket for date picker as well?

Also, looking at the definition for the optional_text and required_text parameters in text-input or text-area, it seems that these are also blocks, but this is not the case in code, it may be necessary to review the definition of the blocks globally on all the forms component? What do you think?


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, let's just do it for the element now, we should align with platform to make sure that we provide what they expect

@papegaill papegaill merged commit 5209e29 into v3.4.0-dev Jun 13, 2022
@papegaill papegaill deleted the fix/FRONT-3651-invalid-icons branch June 13, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants