-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(forms): Add invalid icons for EC and fix them for EU - FRONT-3651 #2554
Conversation
extra_classes: 'ecl-feedback-message__icon', | ||
} only %} | ||
{% endif %} | ||
{{- invalid_text -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should output a block here, same as what is done on the text field for instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, but initially I took this from the date picker where the parameter is not a block, should we create a ticket for date picker as well?
europa-component-library/src/implementations/twig/components/datepicker/datepicker.html.twig
Line 106 in 43ed0a4
{{- invalid_text -}} |
Also, looking at the definition for the optional_text
and required_text
parameters in text-input or text-area, it seems that these are also blocks, but this is not the case in code, it may be necessary to review the definition of the blocks globally on all the forms component? What do you think?
europa-component-library/src/implementations/twig/components/text-input/text-input.html.twig
Line 22 in 43ed0a4
- "required_text" |
europa-component-library/src/implementations/twig/components/text-input/text-input.html.twig
Line 23 in 43ed0a4
- "optional_text" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, let's just do it for the element now, we should align with platform to make sure that we provide what they expect
No description provided.