Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(site_header): Add aria label to language switcher - FRONT-3658 #2565

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Jun 9, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Copy link
Contributor

@papegaill papegaill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change tag?

@emeryro
Copy link
Contributor Author

emeryro commented Jun 13, 2022

@papegaill there should be no breaking change here, I just added an extra parameter.
I also fixed the documentation which was wrongly describing a "name" parameter, while it was in fact already called "label" in the code

@papegaill papegaill merged commit ae8a134 into v3.4.0-dev Jun 13, 2022
@papegaill papegaill deleted the FRONT-3658-aria-label branch June 13, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants