fix(inpage-navigation): Improve accessibility - FRONT-3660 #2568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
requested changes
Jun 16, 2022
| @@ -61,8 +63,7 @@ | |||
| extra_classes: 'ecl-icon--rotate-180 ecl-inpage-navigation__trigger-icon', | |||
| } only %} | |||
| </button> | |||
| <ul class="ecl-inpage-navigation__list" aria-labelledby="ecl-inpage-navigation-trigger" | |||
| data-ecl-inpage-navigation-list="true" id="ecl-inpage-navigation-list"> | |||
| <ul class="ecl-inpage-navigation__list" data-ecl-inpage-navigation-list="true" id="ecl-inpage-navigation-list"> | |||
There was a problem hiding this comment.
we have an id here too, and another one for the trigger, which are hardcoded.
I would suggest to use the id you added in parameter in all cases, and add a suffix to it ("-title", "-list", "-trigger")
emeryro
added
tag: breaking change
process: changes requested
and removed
process: under review
tag: breaking change
labels
emeryro
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.