Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(new-ticker): Improve accessibility - FRONT-3662 #2570

Merged
merged 16 commits into from
Jun 28, 2022
Merged

fix(new-ticker): Improve accessibility - FRONT-3662 #2570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3f32638
fix(new-ticker): Improve accessibility - FRONT-3662
papegaill Jun 17, 2022
2e70563
Merge branch 'v3.4.0-dev' into fix/FRONT-3662
papegaill Jun 20, 2022
3a9c6ce
Review key flow and styles
papegaill Jun 20, 2022
592e3ff
add ellipsis for more than 2 lines
papegaill Jun 21, 2022
13e9a38
Merge branch 'v3.4.0-dev' into fix/FRONT-3662
papegaill Jun 21, 2022
ae584d8
Merge branch 'v3.4.0-dev' into fix/FRONT-3662
papegaill Jun 21, 2022
a29b790
review icon sizes and spacings
papegaill Jun 21, 2022
0ca4540
force ticker height
papegaill Jun 21, 2022
e14404a
add link external position before
papegaill Jun 21, 2022
fd3f744
review content spacing and specs
papegaill Jun 22, 2022
ce58f7e
update snapshot
papegaill Jun 22, 2022
61e1f10
Merge branch 'v3.4.0-dev' into fix/FRONT-3662
papegaill Jun 22, 2022
b62bd45
remove aria-hidden attribute
papegaill Jun 23, 2022
e5999cc
review focus styles
papegaill Jun 23, 2022
7ca667c
Merge branch 'v3.4.0-dev' into fix/FRONT-3662
emeryro Jun 27, 2022
534954d
Merge branch 'v3.4.0-dev' into fix/FRONT-3662
papegaill Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/implementations/twig/components/news-ticker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ npm install --save @ecl/twig-component-news-ticker
- **"counter_label"** (string) (default: 'of')
- **"sr_previous"** (string) (default: 'Previous news') screen reader label for previous button
- **"sr_next"** (string) (default: 'Next news') screen reader label for next button
- **"sr_autoplay"** (string) (default: 'News ticker auto play') screen reader label for autoplay button
- **"sr_play"** (string) (default: 'Play news ticker') screen reader label for the play button
- **"sr_pause"** (string) (default: 'Pause news ticker') screen reader label for the pause button
- **"icon_path"** (string) (default: ''): path to the icons svg
- **"extra_classes"** (optional) (string) (default: '') Extra classes (space separated)
- **"extra_attributes"** (optional) (array) (default: []) Extra attributes
Expand Down
Loading