Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): Improve accessibility - FRONT-3661 #2576

Merged
merged 8 commits into from
Jul 18, 2022
Merged

fix(tabs): Improve accessibility - FRONT-3661 #2576

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f525523
fix(tabs): Improve accessibility - FRONT-3661
papegaill Jun 27, 2022
356129e
Merge branch 'v3.4.0-dev' into fix/FRONT-3661
papegaill Jul 12, 2022
831108c
adapt accessibility key flow
papegaill Jul 13, 2022
174ba59
update snapshot
papegaill Jul 13, 2022
84d0e09
Merge branch 'v3.4.0-dev' into fix/FRONT-3661
planctus Jul 14, 2022
5f85f19
PR feedback
papegaill Jul 14, 2022
ef1e8e8
PR feedback
papegaill Jul 15, 2022
1a7d935
Merge branch 'v3.4.0-dev' into fix/FRONT-3661
planctus Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 72 additions & 6 deletions src/implementations/twig/components/tabs/__snapshots__/tabs.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

exports[`Tabs Default renders correctly 1`] = `
<jest>
<nav
<div
class="ecl-tabs"
data-ecl-auto-init="Tabs"
data-ecl-tabs="true"
role="tablist"
>
<div
class="ecl-tabs__container"
Expand All @@ -17,8 +18,10 @@ exports[`Tabs Default renders correctly 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
>
Item 1 label
</a>
Expand All @@ -27,8 +30,11 @@ exports[`Tabs Default renders correctly 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 2 label
</a>
Expand All @@ -37,8 +43,11 @@ exports[`Tabs Default renders correctly 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 3 label
</a>
Expand All @@ -47,8 +56,11 @@ exports[`Tabs Default renders correctly 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="true"
class="ecl-link ecl-tabs__link ecl-tabs__link--active"
href="/example"
role="tab"
tabindex="-1"
>
Item 4 label
</a>
Expand All @@ -57,8 +69,11 @@ exports[`Tabs Default renders correctly 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 5 label
</a>
Expand All @@ -67,8 +82,11 @@ exports[`Tabs Default renders correctly 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 6 with a very long label
</a>
Expand All @@ -77,8 +95,11 @@ exports[`Tabs Default renders correctly 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 7 label
</a>
Expand All @@ -88,6 +109,7 @@ exports[`Tabs Default renders correctly 1`] = `
>
<button
class="ecl-button ecl-button--secondary ecl-tabs__toggle"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -152,18 +174,19 @@ exports[`Tabs Default renders correctly 1`] = `
/>
</button>
</div>
</nav>
</div>
</jest>
`;

exports[`Tabs Default renders correctly with extra attributes 1`] = `
<jest>
<nav
<div
class="ecl-tabs"
data-ecl-auto-init="Tabs"
data-ecl-tabs="true"
data-test="data-test-value"
data-test-1="data-test-value-1"
role="tablist"
>
<div
class="ecl-tabs__container"
Expand All @@ -175,8 +198,10 @@ exports[`Tabs Default renders correctly with extra attributes 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
>
Item 1 label
</a>
Expand All @@ -185,8 +210,11 @@ exports[`Tabs Default renders correctly with extra attributes 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 2 label
</a>
Expand All @@ -195,8 +223,11 @@ exports[`Tabs Default renders correctly with extra attributes 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 3 label
</a>
Expand All @@ -205,8 +236,11 @@ exports[`Tabs Default renders correctly with extra attributes 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="true"
class="ecl-link ecl-tabs__link ecl-tabs__link--active"
href="/example"
role="tab"
tabindex="-1"
>
Item 4 label
</a>
Expand All @@ -215,8 +249,11 @@ exports[`Tabs Default renders correctly with extra attributes 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 5 label
</a>
Expand All @@ -225,8 +262,11 @@ exports[`Tabs Default renders correctly with extra attributes 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 6 with a very long label
</a>
Expand All @@ -235,8 +275,11 @@ exports[`Tabs Default renders correctly with extra attributes 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 7 label
</a>
Expand All @@ -246,6 +289,7 @@ exports[`Tabs Default renders correctly with extra attributes 1`] = `
>
<button
class="ecl-button ecl-button--secondary ecl-tabs__toggle"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -310,16 +354,17 @@ exports[`Tabs Default renders correctly with extra attributes 1`] = `
/>
</button>
</div>
</nav>
</div>
</jest>
`;

exports[`Tabs Default renders correctly with extra class names 1`] = `
<jest>
<nav
<div
class="ecl-tabs custom-class custom-class--test"
data-ecl-auto-init="Tabs"
data-ecl-tabs="true"
role="tablist"
>
<div
class="ecl-tabs__container"
Expand All @@ -331,8 +376,10 @@ exports[`Tabs Default renders correctly with extra class names 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
>
Item 1 label
</a>
Expand All @@ -341,8 +388,11 @@ exports[`Tabs Default renders correctly with extra class names 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 2 label
</a>
Expand All @@ -351,8 +401,11 @@ exports[`Tabs Default renders correctly with extra class names 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 3 label
</a>
Expand All @@ -361,8 +414,11 @@ exports[`Tabs Default renders correctly with extra class names 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="true"
class="ecl-link ecl-tabs__link ecl-tabs__link--active"
href="/example"
role="tab"
tabindex="-1"
>
Item 4 label
</a>
Expand All @@ -371,8 +427,11 @@ exports[`Tabs Default renders correctly with extra class names 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 5 label
</a>
Expand All @@ -381,8 +440,11 @@ exports[`Tabs Default renders correctly with extra class names 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 6 with a very long label
</a>
Expand All @@ -391,8 +453,11 @@ exports[`Tabs Default renders correctly with extra class names 1`] = `
class="ecl-tabs__item"
>
<a
aria-selected="false"
class="ecl-link ecl-tabs__link"
href="/example"
role="tab"
tabindex="-1"
>
Item 7 label
</a>
Expand All @@ -402,6 +467,7 @@ exports[`Tabs Default renders correctly with extra class names 1`] = `
>
<button
class="ecl-button ecl-button--secondary ecl-tabs__toggle"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -466,6 +532,6 @@ exports[`Tabs Default renders correctly with extra class names 1`] = `
/>
</button>
</div>
</nav>
</div>
</jest>
`;
Loading