Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file-upload): Fix focus styles for the browse button - FRONT-3689 #2591

Merged
merged 7 commits into from
Jul 19, 2022

Conversation

papegaill
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 11, 2022

Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can indeed access the hidden file upload input, but there is no visual indication of it (as it is hidden...)
Is it what is expected?

margin: 0;

// stylelint-disable max-nesting-depth
&:active,
&:focus {
outline: 3px solid map.get(theme.$color, 'yellow');
outline-offset: -3px;
+ .ecl-file-upload__button-container .ecl-file-upload__button {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this code should be in the no-js section

@emeryro emeryro merged commit 12e04cb into v3.4.0-dev Jul 19, 2022
@emeryro emeryro deleted the fix/FRONT-3689 branch July 19, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants