fix(print): fix display of default html tag for print - FRONT-3699 #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planctus
reviewed
Oct 17, 2022
There was a problem hiding this comment.
just one question..is this really meant to be an optional css to be added to the print version of our css or is this just creating an overhead, both on our and the customers side..?
i think this could actually be part of the print css so that no adaptation would be needed for the users to benefit from this, no new resource to be generated and provided with examples every release for it to be included when using ECL.
|
@Plactus to me that's the same thing as the other "html-default" we have. It will only be used by EWPP to cover their need in the wysiwyg. |
planctus
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option css to print elements inside the .ecl class