Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(focus): New styles for checkboxes and radios - FRONT-3770 #2661

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

planctus
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 10, 2022

Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on EC, focus element have an outline in any case, but on EU only the selected checkbox has an outline, the other element only change color
Is that the intended behaviour?
image
image

@planctus
Copy link
Contributor Author

thanks @emeryro , yep, this is the file on figma with the specs:https://www.figma.com/file/Bo9MKSWsatH7qSdjZwxMEe/Form-Elements for eu, as in the initial comment for this pr the things that are not fully aligned with what you find there should be the focus on error state and the size of the selected-focused checkbox in eu.

@planctus planctus removed the Question label Oct 12, 2022
@emeryro emeryro merged commit f563529 into v3.5.0-dev Oct 17, 2022
@emeryro emeryro deleted the FRONT-3770-Focus-style branch October 17, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants