Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rating-field): add read only #2699

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Nov 28, 2022

Add a parameter to display the rating field as read only

@github-actions
Copy link

github-actions bot commented Nov 28, 2022

Copy link
Contributor

@planctus planctus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question...
In html we have "disabled" but also "readonly", now it seems we are mixing them up since we say that a disabled form element/group is a readonly one.
The difference is that the readonly input still submits the value, disabled doesn't and here it really seems that what we want is a "readonly" field more than a disabled one, since we set a value for it, i would expect that to be part of the submitted form values.

@emeryro
Copy link
Contributor Author

emeryro commented Nov 29, 2022

That's a valid question, but I'd say that it will depend on the needs.
For now, the reported need is from eUi, to display the value of the rating in a listing, oustside of any form. So that correspond to what we have here.

@emeryro emeryro merged commit 534c6c9 into v3.6.0-dev Nov 30, 2022
@emeryro emeryro deleted the FRONT-3797-rating-read-only branch November 30, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants