Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): Grouping capabilities for simple and multiple select - FRONT-3542 #2712

Merged
merged 21 commits into from
Feb 1, 2023

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Dec 8, 2022

  • this is only adding the support for optgroups in the default and multiple select
  • in the mocks there are now styles for the default select that were not foreseen and cannot be reproduced simply with some css, these styles have not been "reproduced".
  • It is pretty limited as a functionality, we do support groups in the multiselect but as simple strings, no functionality is associated to it (like selecting all the options in the group)

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

emeryro
emeryro previously approved these changes Dec 19, 2022
@emeryro
Copy link
Contributor

emeryro commented Jan 26, 2023

The hover area of item in groups is quite strange
image
I guess that it is a mistake, as the click area goes on the full width

@emeryro
Copy link
Contributor

emeryro commented Jan 26, 2023

Also the cursor does not seem consitent. For instance title have a hand cursor while they are not clickable, and hover area has a default cursor
image

emeryro
emeryro previously approved these changes Jan 31, 2023
@emeryro emeryro merged commit 8b16ea8 into v3.7.0-dev Feb 1, 2023
@emeryro emeryro deleted the FRONT-3542-optgroup branch February 1, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants