-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fact and figures): update component display - FRONT-3840 #2737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small issue in the story file, couple of suggestions
@@ -122,8 +127,8 @@ export default { | |||
}; | |||
|
|||
export const Default = (args) => | |||
factFigures(prepareData(correctPaths(data3Col), args)); | |||
factFigures(prepareData(correctPaths(demoData), args)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you pass the data through correctPaths() already in prepareData(), now.. ;)
} | ||
// Column display | ||
clone.column = args.column; | ||
if (args.column < 3) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a ternary operator, here..? you can leave it like it is if you prefer it, eh, there is nothing wrong with it.
Update spacing and typography, and allows display on 1 to 4 columns