feat(modal): add modal component - FRONT-3858 #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planctus
requested changes
Feb 28, 2023
emeryro
added
process: review needed
process: WIP
and removed
process: changes requested
process: review needed
labels
planctus
requested changes
Mar 9, 2023
| @use 'sass:map'; | ||
| @use '@ecl/theme-dev/theme'; | ||
|
|
||
| .ecl-modal { |
There was a problem hiding this comment.
Now it looks much better, but there is no margin between the two buttons:
This only happens when enabling also the "default-print" css
| {%- block header %}{{ _header }}{% endblock -%} | ||
| </div> | ||
| {% endif %} | ||
|
|
There was a problem hiding this comment.
also here i would add a check for the icon_path not being empty to determine whether to pass also the icon or just the button.
|
For the buttons, I'm not sure that it is a real case. The ecl-print-default css is not supposed to be used when not printing (so with the "normal" ECL css), and if you have the ecl-print css it is displayed correctly (even with the ecl-print-default) |
planctus
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.