Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improving keyboard navigation for carousel, updating EU styles for focus in radio - FRONT-3870 #2781

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Feb 27, 2023

In this pr:

  1. updated kayboard navigation for carousel, moving to the selected slide from the play/pause button, then selecting the slide as the user moves to the next or previous item
  2. updates on the styles for radio, it is now aligned to the EC style

No change was needed regarding the keyboard navigation for radio, the request was that when focusing on the radio group, if none is yet selected, the first radio gets focused but not checked, and it was already the case.

@github-actions
Copy link

github-actions bot commented Feb 27, 2023

@planctus planctus marked this pull request as ready for review March 1, 2023 08:22
@planctus planctus requested a review from a team March 1, 2023 08:22
@planctus planctus changed the title feat(focus): Updates on carousel - FRONT-3870 feat: Improving keyboard navigation for carousel, updating EU styles for focus in radio - FRONT-3870 Mar 1, 2023
@emeryro emeryro merged commit a69a337 into v3.8.0-dev Mar 6, 2023
@emeryro emeryro deleted the FRONT-3870-Focus-update branch March 6, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants