feat(picture): add picture component - FRONT-3868 #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planctus
requested changes
Mar 6, 2023
| ... | ||
| ] | ||
| - "picture_class" (optional) (string) (default: '') | ||
| - "image_class" (optional) (string) (default: '') |
There was a problem hiding this comment.
our templates have extra_classes and extra_attributes by "default" forthe root element, why aren't we using them here..?
| <source srcset="{{ _source.src|default('') }}" media="{{ _source.media|default('') }}" type="{{ _source.type|default('') }}"> | ||
| {% endfor %} | ||
| {% endif %} | ||
| <img class="{{ _image_class }}" src="{{ _picture.img.src|default('') }}" alt="{{ _picture.img.alt|default('') }}" /> |
There was a problem hiding this comment.
It seems we should add some checks here before rendering stuff, all these attributes might not have any value and we would render them empty.
It also feels that this data structure gets too structured in order to have a single object, the img object is nested into the picture one, but ok let's keep it like this.
planctus
approved these changes
Mar 6, 2023
planctus
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add component to handle the display of images by using the html picture tag