feat(site-header): Using picture, keeping data structure unchanged - FRONT-3882 #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
reviewed
Mar 23, 2023
|
Fascinating, i did this on my own and then i read your comment.. :) |
emeryro
requested changes
Mar 28, 2023
| media="(min-width: 996px)" | ||
| srcset="/standard-version/positive/logo-eu--en.svg" | ||
| /> | ||
| <source |
There was a problem hiding this comment.
this second source is not needed. By default it will take the image in the img tag (mobile) and switch to desktop
| @@ -78,16 +78,12 @@ $_search-width-xl: 31.5rem; | |||
| flex-grow: 1; | |||
| } | |||
|
|
|||
| .ecl-site-header__logo-image-mobile { | |||
There was a problem hiding this comment.
if we remove the previous css class definition, that would be a breaking change
So we should either keep them (deprecated) or flag the pr as breaking
emeryro
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use picture tag to handle logo
Note: for EU, the change of logo between mobile and desktop is now handled with the picture source