feat(media-container): add expandable - FRONT-4017 #2943
Conversation
|
Question: where is "Infography" coming from..? :) Is this an english word..? Shouldn't it be infographic..? |
| @@ -81,6 +83,10 @@ | |||
| {% set _css_class = _css_class ~ ' ' ~ extra_classes %} | |||
| {% endif %} | |||
|
|
|||
| {% if _expandable is not empty and _expandable.id is defined %} | |||
There was a problem hiding this comment.
why not setting this as an item of extra_attributes instead of building the string manually?
src/implementations/twig/components/media-container/media-container.html.twig
Outdated
Show resolved
Hide resolved
src/implementations/twig/components/media-container/media-container.html.twig
Outdated
Show resolved
Hide resolved
|
thanks for the feedback @planctus |
|
|
||
| {% if _expandable is not empty %} | ||
| {% include '@ecl/expandable/expandable.html.twig' with _expandable|merge({ | ||
| extra_classes: _expandable_class, |
There was a problem hiding this comment.
doing this would override existing extra_classes in the data, i think we should merge this class with the others, if present.
| @@ -223,7 +224,10 @@ const prepareData = (data, args) => { | |||
|
|
|||
| const renderStory = (data, args) => { | |||
| let story = banner(prepareData(data, args)); | |||
| if (args.width === 'container' || args.width === 'inside') { | |||
| if ( | |||
| args.width === 'inside the grid container' || | |||
There was a problem hiding this comment.
it felt there was something strange since you are receiving the labels and not the values in the args object, this is due to a reverse mapping, it should be:
mapping: {
'outside the ecl-container': 'outside',
'inside the ecl-container': 'container',
'inside the ecl-container, with fullwidth class': 'inside',
},
and then you would deal with the values here, the same in the url ;)
Main component css classes have been put a level higher, in a container, to be able to add an optional expandable block.
also fix some missing dependencies for picture component