Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): fix rtl full screen display - FRONT-4081 #3024

Merged
merged 6 commits into from Sep 11, 2023

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Sep 11, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 11, 2023

@github-actions github-actions bot temporarily deployed to pull request September 11, 2023 06:46 Inactive
Copy link
Contributor

@planctus planctus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmmh..ok, but i think we can take the chance to fix some other issue with this story:

  • size and demo grid content need a mapping or a fix to their mapping, they are not kept in permalinks

@emeryro
Copy link
Contributor Author

emeryro commented Sep 11, 2023

I added the mapping for the size, but for the boolean I'm not sure what to do.
I checked other stories, sometimes the arg is kept in the url, sometimes not, but I didn't find any pattern to make it work every time...

@github-actions github-actions bot temporarily deployed to pull request September 11, 2023 09:35 Inactive
@planctus
Copy link
Contributor

I know it feels silly, and i also think this is a regression in storybook, booleans used to work even without an explicit mapping, in any case it's like this:

      mapping: {
        0: false,
        1: true,
      },

:D

@github-actions github-actions bot temporarily deployed to pull request September 11, 2023 11:17 Inactive
@planctus
Copy link
Contributor

Oh gosh... now that these mapping work try to get the link with the "grid content" and/or a size set, the carousel misbehaves..but ok, maybe this is for another investigation..
image

@planctus planctus merged commit 4ec5a12 into v3-dev Sep 11, 2023
7 checks passed
@planctus planctus deleted the FRONT-4081-carousel-rtl branch September 11, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants