feat(table): add accessibility scope - FRONT-4259 #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planctus
reviewed
Mar 20, 2024
| {% elseif cell.label is not empty and _sortable %} | ||
| {% set _heading_attribute = _heading_attribute ~ ' data-ecl-table-sort-toggle' %} | ||
| {% endif %} | ||
| {% set _heading_attribute = _heading_attribute ~ ' scope="' ~ _heading_scope|e('html_attr') ~ '"' %} |
There was a problem hiding this comment.
we don't really need to filter the string we have just defined with the escape filter here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scopeattribute to the table header