feat(table): add optional caption - FRONT-4274 #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planctus
reviewed
Mar 25, 2024
| @@ -73,6 +73,14 @@ $table: null !default; | |||
| } | |||
| } | |||
|
|
|||
| .ecl-table__caption { | |||
| caption-side: bottom; | |||
There was a problem hiding this comment.
considering that most likely we will receive requests to make this position parametrical, why don't we add this option already?
There was a problem hiding this comment.
The position has been decided by the designers.
So, sure, we could make it as a parameter, but this may be just an option never used. I'd rather wait to have a use case
planctus
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
captionis provided to add it easily