fix(menu): Bring the user back to the open/close button when reaching the last item in mobile - FRONT-4288 #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the last item in mobile - FRONT-4288
planctus
added
process: WIP
and removed
process: business approval needed
tag: bug fix
labels
planctus
added
tag: bug fix
process: review needed
process: business approval needed
and removed
process: WIP
labels
emeryro
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still an issue in the storybook demo, using the "open in a new canvas" the problem can still be reproduced, suprisingly enough only the first time, if you keep tabbing from the second iteration the trap works as expected.
But this is not a real use case, we don't have anything after the menu in the demo, but in the real world there is an entire webpage to set the focus on and in that case the functionality works as expected.