Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(featured-item): fix picture spacing - FRONT-4310 #3294

Merged
merged 4 commits into from Mar 19, 2024
Merged

fix(featured-item): fix picture spacing - FRONT-4310 #3294

merged 4 commits into from Mar 19, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Mar 19, 2024 •
edited

  • fix spacing around the picture on EU, for highlighted variant
  • fix mobile spacing
  • fix border radius for EU

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited

🚀 Deployed on https://ecl-preview-3294--europa-component-library.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 19, 2024 07:15 Inactive
@planctus
Copy link
Contributor

In mobile we have this:
image
We used to have only a padding bottom in mobile for the highlighted, now we get also a padding left

@planctus planctus self-requested a review March 19, 2024 07:36
@emeryro
Copy link
Contributor Author

emeryro commented Mar 19, 2024

In fact, the mobile spacing was wrong already, with some right/left spacing remaining.
It should be fine now

@github-actions github-actions bot temporarily deployed to pull request March 19, 2024 08:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 19, 2024 08:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 19, 2024 09:45 Inactive
@planctus planctus merged commit 113a937 into v4-dev Mar 19, 2024
7 checks passed
@planctus planctus deleted the FRONT-4310-featured-item-spacing branch March 19, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planctus planctus Awaiting requested review from planctus

Assignees
No one assigned
Labels
tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emeryro @planctus