Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): Removing buggy animation of the arrow in the default select - FRONT-4348 #3318

Merged
merged 8 commits into from Apr 9, 2024

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Apr 2, 2024

No description provided.

Copy link

github-actions bot commented Apr 2, 2024

@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 11:46 Inactive
@emeryro
Copy link
Contributor

emeryro commented Apr 2, 2024

not sure what is the issue here, but on my side the arrow animation still doesn't work as expected.
The arrow only rotate while I'm holding the mouse click, and goes back to default when I release it (regardless of the open/close status).
With the keyboard it's better, but still the arrow doesn't goes back to default when pressing escape

@planctus
Copy link
Contributor Author

planctus commented Apr 2, 2024

The issue is that currently, if you click outside of the select to close it, the animation doesn't work anymore, in this pull request this is fixed, but it's true that we cannot fully handle the first usage of Esc, which results in closing the dropdown without animating the select, but this is a minor issue to me, considering that when you move the focus out the arrow will go back to its default position.
I read what you described about the behaviour, i do not see that, for me it works fine using the mouse, you click it opens the dropdown and rotates the icon, clicking again will close the dropdown and rotate again the icon.

Aside of this, why do we have this huge difference in the icon size for the single and the multiple select now..?

@planctus planctus removed the Question label Apr 2, 2024
@emeryro
Copy link
Contributor

emeryro commented Apr 2, 2024

I don't know if we are talking about the same thing, but on my side the arrow animation doesn't work at all with the mouse (unless I keep the button pressed). Clicking outside the select or not does no difference.
simple click
2024-04-02-select-click

"long" click
2024-04-02-select-click-long

For the arrow styling, I don't know... They are indeed quite different, but I don't know if that was intentional. We'll see with the designers tomorrow

@planctus planctus changed the title fix(select): Fixing animation of the arrow in default select - FRONT-4348 fix(select): Removing buggy animation of the arrow in the default select - FRONT-4348 Apr 4, 2024
@planctus
Copy link
Contributor Author

planctus commented Apr 4, 2024

Tried a bit more, but it seems really impossible to produce a logic that would work for all the browsers and it's also confirmed by the literature on internet, so i removed the animation from the default select.

@github-actions github-actions bot temporarily deployed to pull request April 4, 2024 12:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 4, 2024 12:25 Inactive
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I have a js error when trying to open the select with the keyboard:
image

@@ -15,7 +15,7 @@ const iconSize = system === 'eu' ? 's' : 'xs';

/**
* This API mostly refers to the multiple select, in the default select only three methods are actually used:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This API mostly refers to the multiple select, in the default select only three methods are actually used:
* This API mostly refers to the multiple select, in the default select only two methods are actually used:

@github-actions github-actions bot temporarily deployed to pull request April 8, 2024 12:43 Inactive
@emeryro emeryro merged commit 1b6b9b7 into v4-dev Apr 9, 2024
7 checks passed
@emeryro emeryro deleted the FRONT-4348-Default-select-animation branch April 9, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants