Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

ISAICP-6632: Update the EIRA_SKOS file. #2538

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

saidatom
Copy link
Contributor

@saidatom saidatom commented Aug 4, 2021

No description provided.

Copy link
Contributor

@pfrenssen pfrenssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with the update - there are solutions currently in Joinup that are using deprecated EIRA terms which have been removed in the new version. After running the update these solutions have lost their "Solution type" which means the data model is not complete.

We should map these obsolete EIRA terms to new ones if a replacement has been suggested, but in the case no replacement is available it is not clear how to proceed. Probably we need to make an inventory of solutions using deprecated terms and contact them / update them manually.

Comment on lines -1 to -5
@api
Feature:
As a user of the website
When I go to the overview page of an EIRA term
I want to be able to see if a term is deprecated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is a good idea to remove this test since it will leave the functionality untested. Probably the new catalog doesn't contain any deprecated terms but it is always possible that terms will be deprecated again in the future.

Maybe we can add a Background section here which adds 2 deprecated terms (one with a replacement and one without) which can then be used in the test scenarios.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants