Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscription): Add operation subscription with filter on source/destination/hash/kind #188

Merged
merged 6 commits into from
Dec 4, 2019

Conversation

carte7000
Copy link
Contributor

@carte7000 carte7000 commented Dec 2, 2019

RPC based stream provider now supports operation stream with filter on hash/source/destination/kind

  • SubscribeProvider interfaces are now exported from taquito package
  • RPC based stream provider have been refactored to use rxjs
  • Mark WebSocket based streamer package as temporary unmaintained

BREAKING CHANGES

  • WS streamer package is now in an unmaintained state
  • Subscription type from SubscribeProvider is now generic might break some implementation of SubscribeProvider implementation

closes #186

…destination/hash/kind

RPC based stream provider now support operation stream with filter on hash/source/destination/kind

 Subscribe interface is now exported from taquito package
RPC based stream provider have been
refactored to use rxjs
 Mark websocket based streamer package as temporary unmaintained

BREAKING CHANGE: WS streamer package is now in an unmaintained state
 Subscription type from
SubscribeProvider is now generic might break some implementation of SubscribeProvider implementation

closes #186
@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #188 into master will decrease coverage by 0.74%.
The diff coverage is 35.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   76.28%   75.54%   -0.75%     
==========================================
  Files          73       75       +2     
  Lines        2412     2482      +70     
  Branches      505      526      +21     
==========================================
+ Hits         1840     1875      +35     
- Misses        571      604      +33     
- Partials        1        3       +2
Impacted Files Coverage Δ
packages/taquito/src/contract/manager-lambda.ts 55.55% <ø> (ø) ⬆️
packages/taquito/src/taquito.ts 95.74% <ø> (ø) ⬆️
packages/taquito-streamer/src/taquito-streamer.ts 0% <0%> (ø) ⬆️
packages/taquito/src/forger/rpc-forger.ts 100% <100%> (ø) ⬆️
...s/taquito/src/subscribe/observable-subscription.ts 16.98% <16.98%> (ø)
packages/taquito/src/subscribe/polling-provider.ts 50% <47.82%> (+31.35%) ⬆️
packages/taquito/src/subscribe/filters.ts 48.07% <48.07%> (ø)
...o-tezbridge-signer/src/taquito-tezbridge-signer.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6891931...b1e8450. Read the comment docs.

@carte7000
Copy link
Contributor Author

An example on how to use the API need to be added before merging the PR

@carte7000 carte7000 merged commit 26f52e1 into master Dec 4, 2019
@carte7000 carte7000 deleted the 186-operation-filter-on-streaming-api branch December 4, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming implementation that polls RPC
3 participants