-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2306 contract api sr originate #2349
Conversation
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages:
|
packages/taquito/src/operations/smart-rollup-originate-operation.ts
Outdated
Show resolved
Hide resolved
35b0b1b
to
57cd3f0
Compare
d8dd410
to
8a91cb8
Compare
80c596b
to
479701b
Compare
packages/taquito/src/operations/smart-rollup-originate-operation.ts
Outdated
Show resolved
Hide resolved
packages/taquito/src/operations/smart-rollup-originate-operation.ts
Outdated
Show resolved
Hide resolved
@zainen missing batch support and tests for batching |
ahh ok right I'll add that |
A new deploy preview is available on Netlify at https://7df9081--tezostaquito.netlify.app |
ba81cf6
to
3b5592d
Compare
@@ -74,6 +75,7 @@ export type MergedOperationResult = OperationResultTransaction & | |||
OperationResultTxRollupOrigination & | |||
OperationResultTxRollupSubmitBatch & | |||
OperationResultTransferTicket & | |||
Partial<OperationResultSmartRollupOriginate> & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why partial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because otherwise it is expected that other operations have items that are specific to smartRollupOriginate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise the other types are expected to have the same expected key item pairs
608cb2e
to
ecff8b4
Compare
feat: continue support, need estimate fix for storageLimit and returned estimate fix: fix test value. needs debug of storageLimit fix: properly estimate smart rollup originate however needs better way refactor: remove some unneeded expects refactor: better place for storage_limit fix: change back to update estimate provider storage limit fix: fix any types docs: add website docs for smart rollups fix: fix failing test debugging expect refactor: refactor and add test refactor: add enum in proper place fix: fix test not using req type refactor: remove unneeded refactor: fix return description fix: add rpc method to get origination proof and modify tests and methods docs: better wording, add slight test expect change fix: change mumbai proto test: add test for rpc end point remove , fix: test name and missing space fix: fix descrip fix: consistency reqs -> params fix: try estimation for smart rollup originate. add batch fix: check metadata for size and apply to storage limit docs: reword add rpc addition test: change lima check for updated node v16 octez test: update test for lima flextesa test: fix test condidtions fix: zainensuzuki in ~ λ cd code/taquito > tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach. adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts fix: remove type cast
ecff8b4
to
19bc76d
Compare
integration-tests/injecting-multiple-manager-operations-in-a-block.spec.ts
Outdated
Show resolved
Hide resolved
integration-tests/injecting-multiple-manager-operations-in-a-block.spec.ts
Outdated
Show resolved
Hide resolved
* feat: 2306 start work on support pre local forger support feat: continue support, need estimate fix for storageLimit and returned estimate fix: fix test value. needs debug of storageLimit fix: properly estimate smart rollup originate however needs better way refactor: remove some unneeded expects refactor: better place for storage_limit fix: change back to update estimate provider storage limit fix: fix any types docs: add website docs for smart rollups fix: fix failing test debugging expect refactor: refactor and add test refactor: add enum in proper place fix: fix test not using req type refactor: remove unneeded refactor: fix return description fix: add rpc method to get origination proof and modify tests and methods docs: better wording, add slight test expect change fix: change mumbai proto test: add test for rpc end point remove , fix: test name and missing space fix: fix descrip fix: consistency reqs -> params fix: try estimation for smart rollup originate. add batch fix: check metadata for size and apply to storage limit docs: reword add rpc addition test: change lima check for updated node v16 octez test: update test for lima flextesa test: fix test condidtions fix: zainensuzuki in ~ λ cd code/taquito > tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach. adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts fix: remove type cast * test: add tests * refactor: remove unused constant * fix: pr comments * fix: pr comments * fix: pr comments --------- Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
* feat: 2306 start work on support pre local forger support feat: continue support, need estimate fix for storageLimit and returned estimate fix: fix test value. needs debug of storageLimit fix: properly estimate smart rollup originate however needs better way refactor: remove some unneeded expects refactor: better place for storage_limit fix: change back to update estimate provider storage limit fix: fix any types docs: add website docs for smart rollups fix: fix failing test debugging expect refactor: refactor and add test refactor: add enum in proper place fix: fix test not using req type refactor: remove unneeded refactor: fix return description fix: add rpc method to get origination proof and modify tests and methods docs: better wording, add slight test expect change fix: change mumbai proto test: add test for rpc end point remove , fix: test name and missing space fix: fix descrip fix: consistency reqs -> params fix: try estimation for smart rollup originate. add batch fix: check metadata for size and apply to storage limit docs: reword add rpc addition test: change lima check for updated node v16 octez test: update test for lima flextesa test: fix test condidtions fix: zainensuzuki in ~ λ cd code/taquito > tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach. adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts fix: remove type cast * test: add tests * refactor: remove unused constant * fix: pr comments * fix: pr comments * fix: pr comments --------- Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
* feat: 2306 start work on support pre local forger support feat: continue support, need estimate fix for storageLimit and returned estimate fix: fix test value. needs debug of storageLimit fix: properly estimate smart rollup originate however needs better way refactor: remove some unneeded expects refactor: better place for storage_limit fix: change back to update estimate provider storage limit fix: fix any types docs: add website docs for smart rollups fix: fix failing test debugging expect refactor: refactor and add test refactor: add enum in proper place fix: fix test not using req type refactor: remove unneeded refactor: fix return description fix: add rpc method to get origination proof and modify tests and methods docs: better wording, add slight test expect change fix: change mumbai proto test: add test for rpc end point remove , fix: test name and missing space fix: fix descrip fix: consistency reqs -> params fix: try estimation for smart rollup originate. add batch fix: check metadata for size and apply to storage limit docs: reword add rpc addition test: change lima check for updated node v16 octez test: update test for lima flextesa test: fix test condidtions fix: zainensuzuki in ~ λ cd code/taquito > tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach. adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts fix: remove type cast * test: add tests * refactor: remove unused constant * fix: pr comments * fix: pr comments * fix: pr comments --------- Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
* feat: 2306 start work on support pre local forger support feat: continue support, need estimate fix for storageLimit and returned estimate fix: fix test value. needs debug of storageLimit fix: properly estimate smart rollup originate however needs better way refactor: remove some unneeded expects refactor: better place for storage_limit fix: change back to update estimate provider storage limit fix: fix any types docs: add website docs for smart rollups fix: fix failing test debugging expect refactor: refactor and add test refactor: add enum in proper place fix: fix test not using req type refactor: remove unneeded refactor: fix return description fix: add rpc method to get origination proof and modify tests and methods docs: better wording, add slight test expect change fix: change mumbai proto test: add test for rpc end point remove , fix: test name and missing space fix: fix descrip fix: consistency reqs -> params fix: try estimation for smart rollup originate. add batch fix: check metadata for size and apply to storage limit docs: reword add rpc addition test: change lima check for updated node v16 octez test: update test for lima flextesa test: fix test condidtions fix: zainensuzuki in ~ λ cd code/taquito > tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach. adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts fix: remove type cast * test: add tests * refactor: remove unused constant * fix: pr comments * fix: pr comments * fix: pr comments --------- Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
* feat: 2306 start work on support pre local forger support feat: continue support, need estimate fix for storageLimit and returned estimate fix: fix test value. needs debug of storageLimit fix: properly estimate smart rollup originate however needs better way refactor: remove some unneeded expects refactor: better place for storage_limit fix: change back to update estimate provider storage limit fix: fix any types docs: add website docs for smart rollups fix: fix failing test debugging expect refactor: refactor and add test refactor: add enum in proper place fix: fix test not using req type refactor: remove unneeded refactor: fix return description fix: add rpc method to get origination proof and modify tests and methods docs: better wording, add slight test expect change fix: change mumbai proto test: add test for rpc end point remove , fix: test name and missing space fix: fix descrip fix: consistency reqs -> params fix: try estimation for smart rollup originate. add batch fix: check metadata for size and apply to storage limit docs: reword add rpc addition test: change lima check for updated node v16 octez test: update test for lima flextesa test: fix test condidtions fix: zainensuzuki in ~ λ cd code/taquito > tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach. adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts fix: remove type cast * test: add tests * refactor: remove unused constant * fix: pr comments * fix: pr comments * fix: pr comments --------- Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
* 2306 contract api sr originate (#2349) * feat: 2306 start work on support pre local forger support feat: continue support, need estimate fix for storageLimit and returned estimate fix: fix test value. needs debug of storageLimit fix: properly estimate smart rollup originate however needs better way refactor: remove some unneeded expects refactor: better place for storage_limit fix: change back to update estimate provider storage limit fix: fix any types docs: add website docs for smart rollups fix: fix failing test debugging expect refactor: refactor and add test refactor: add enum in proper place fix: fix test not using req type refactor: remove unneeded refactor: fix return description fix: add rpc method to get origination proof and modify tests and methods docs: better wording, add slight test expect change fix: change mumbai proto test: add test for rpc end point remove , fix: test name and missing space fix: fix descrip fix: consistency reqs -> params fix: try estimation for smart rollup originate. add batch fix: check metadata for size and apply to storage limit docs: reword add rpc addition test: change lima check for updated node v16 octez test: update test for lima flextesa test: fix test condidtions fix: zainensuzuki in ~ λ cd code/taquito > tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach. adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts fix: remove type cast * test: add tests * refactor: remove unused constant * fix: pr comments * fix: pr comments * fix: pr comments --------- Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local> * test: change test to all testnets --------- Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
add support for
smart_rollup_originate
operationcloses #2306
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBER
in the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.