Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2306 contract api sr originate #2349

Merged
merged 6 commits into from
Mar 28, 2023
Merged

2306 contract api sr originate #2349

merged 6 commits into from
Mar 28, 2023

Conversation

zainen
Copy link
Contributor

@zainen zainen commented Feb 21, 2023 •
edited

add support for smart_rollup_originate operation

closes #2306
Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/michelson-encoder@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michel-codec@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/contracts-library@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/beacon-wallet@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/utils@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/rpc@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/ledger-signer@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/local-forging@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip16@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/signer@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/remote-signer@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/sapling@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/http-utils@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip12@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/taquito@16.0.0-7df9081-- --registry https://npm.preview.tezostaquito.io/

@zainen zainen force-pushed the 2306-contract-api-sr-originate branch from 35b0b1b to 57cd3f0 Compare February 28, 2023 21:34
@zainen zainen force-pushed the 2306-contract-api-sr-originate branch from d8dd410 to 8a91cb8 Compare March 9, 2023 20:57
@zainen zainen requested a review from hui-an-yang March 9, 2023 21:31
@zainen zainen force-pushed the 2306-contract-api-sr-originate branch 2 times, most recently from 80c596b to 479701b Compare March 10, 2023 01:19
@zainen zainen requested a review from hui-an-yang March 13, 2023 18:16
@zainen zainen requested a review from hui-an-yang March 13, 2023 22:05
@zainen zainen requested a review from hui-an-yang March 13, 2023 23:08
dsawali
dsawali requested changes Mar 13, 2023
View reviewed changes
integration-tests/contract-smart-rollup-originate.spec.ts Show resolved Hide resolved
integration-tests/contract-smart-rollup-originate.spec.ts Outdated Show resolved Hide resolved
packages/taquito-contracts-library/src/rpc-wrapper.ts Outdated Show resolved Hide resolved
packages/taquito/src/contract/rpc-contract-provider.ts Outdated Show resolved Hide resolved
packages/taquito/src/contract/rpc-contract-provider.ts Show resolved Hide resolved
packages/taquito/src/estimate/rpc-estimate-provider.ts Outdated Show resolved Hide resolved
packages/taquito/src/estimate/rpc-estimate-provider.ts Outdated Show resolved Hide resolved
packages/taquito/src/estimate/rpc-estimate-provider.ts Outdated Show resolved Hide resolved
packages/taquito/test/contract/rpc-contract-provider.spec.ts Show resolved Hide resolved
packages/taquito/test/prepare/prepare-provider.spec.ts Show resolved Hide resolved
@dsawali
Copy link
Collaborator

dsawali commented Mar 13, 2023

@zainen missing batch support and tests for batching

@zainen
Copy link
Contributor Author

zainen commented Mar 14, 2023

@zainen missing batch support and tests for batching

ahh ok right I'll add that

@zainen zainen requested a review from dsawali March 15, 2023 22:48
Base automatically changed from mumbai to master March 16, 2023 18:04
@github-actions
Copy link

github-actions bot commented Mar 16, 2023 •
edited

A new deploy preview is available on Netlify at https://7df9081--tezostaquito.netlify.app

@zainen zainen force-pushed the 2306-contract-api-sr-originate branch from ba81cf6 to 3b5592d Compare March 21, 2023 19:07
dsawali
dsawali requested changes Mar 21, 2023
View reviewed changes
packages/taquito/src/estimate/rpc-estimate-provider.ts Outdated Show resolved Hide resolved
packages/taquito/src/estimate/rpc-estimate-provider.ts Outdated Show resolved Hide resolved
packages/taquito/src/operations/operation-errors.ts
@@ -74,6 +75,7 @@ export type MergedOperationResult = OperationResultTransaction &
OperationResultTxRollupOrigination &
OperationResultTxRollupSubmitBatch &
OperationResultTransferTicket &
Partial<OperationResultSmartRollupOriginate> &
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why partial?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because otherwise it is expected that other operations have items that are specific to smartRollupOriginate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise the other types are expected to have the same expected key item pairs

packages/taquito/src/operations/types.ts Show resolved Hide resolved
packages/taquito/test/contract/rpc-contract-provider.spec.ts Show resolved Hide resolved
packages/taquito/test/prepare/prepare-provider.spec.ts Show resolved Hide resolved
@zainen zainen requested a review from dsawali March 21, 2023 23:56
@zainen zainen force-pushed the 2306-contract-api-sr-originate branch from 608cb2e to ecff8b4 Compare March 23, 2023 19:23
Zainen Suzuki added 3 commits March 27, 2023 12:27
feat: 2306 start work on support pre local forger support
e455a24 
feat: continue support, need estimate fix for storageLimit and returned estimate

fix: fix test value. needs debug of storageLimit

fix: properly estimate smart rollup originate however needs better way

refactor: remove some unneeded expects

refactor: better place for storage_limit

fix: change back to update estimate provider storage limit

fix: fix any types

docs: add website docs for smart rollups

fix: fix failing test debugging expect

refactor: refactor and add test

refactor: add enum in proper place

fix: fix test not using req type

refactor: remove unneeded

refactor: fix return description

fix: add rpc method to get origination proof and modify tests and methods

docs: better wording, add slight test expect change

fix: change mumbai proto

test: add test for rpc end point

remove ,

fix: test name and missing space

fix: fix descrip

fix: consistency reqs -> params

fix: try estimation for smart rollup originate. add batch

fix: check metadata for size and apply to storage limit

docs: reword add rpc addition

test: change lima check for updated node v16 octez

test: update test for lima flextesa

test: fix test condidtions

fix: zainensuzuki in ~ λ cd code/taquito

> tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach.
adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts

fix: remove type cast
test: add tests
ad2f2f8
refactor: remove unused constant
19bc76d
@zainen zainen force-pushed the 2306-contract-api-sr-originate branch from ecff8b4 to 19bc76d Compare March 27, 2023 19:27
dsawali
dsawali requested changes Mar 27, 2023
View reviewed changes
docs/rpc_package.md Outdated Show resolved Hide resolved
integration-tests/contract-smart-rollup-originate.spec.ts Outdated Show resolved Hide resolved
integration-tests/contract-smart-rollup-originate.spec.ts Outdated Show resolved Hide resolved
integration-tests/injecting-multiple-manager-operations-in-a-block.spec.ts Outdated Show resolved Hide resolved
integration-tests/injecting-multiple-manager-operations-in-a-block.spec.ts Outdated Show resolved Hide resolved
packages/taquito-rpc/src/taquito-rpc.ts Outdated Show resolved Hide resolved
packages/taquito-rpc/src/rpc-client-modules/rpc-cache.ts Outdated Show resolved Hide resolved
packages/taquito/src/batch/rpc-batch-provider.ts Outdated Show resolved Hide resolved
packages/taquito/src/contract/rpc-contract-provider.ts Outdated Show resolved Hide resolved
packages/taquito/src/estimate/rpc-estimate-provider.ts Outdated Show resolved Hide resolved
@zainen zainen requested a review from dsawali March 27, 2023 20:37
dsawali
dsawali approved these changes Mar 28, 2023
View reviewed changes
docs/smart_rollups.md Outdated Show resolved Hide resolved
@zainen zainen merged commit defe860 into master Mar 28, 2023
@zainen zainen deleted the 2306-contract-api-sr-originate branch March 28, 2023 21:18
zainen added a commit that referenced this pull request Mar 30, 2023
@zainen
2306 contract api sr originate (#2349)
bb44513 
* feat: 2306 start work on support pre local forger support

feat: continue support, need estimate fix for storageLimit and returned estimate

fix: fix test value. needs debug of storageLimit

fix: properly estimate smart rollup originate however needs better way

refactor: remove some unneeded expects

refactor: better place for storage_limit

fix: change back to update estimate provider storage limit

fix: fix any types

docs: add website docs for smart rollups

fix: fix failing test debugging expect

refactor: refactor and add test

refactor: add enum in proper place

fix: fix test not using req type

refactor: remove unneeded

refactor: fix return description

fix: add rpc method to get origination proof and modify tests and methods

docs: better wording, add slight test expect change

fix: change mumbai proto

test: add test for rpc end point

remove ,

fix: test name and missing space

fix: fix descrip

fix: consistency reqs -> params

fix: try estimation for smart rollup originate. add batch

fix: check metadata for size and apply to storage limit

docs: reword add rpc addition

test: change lima check for updated node v16 octez

test: update test for lima flextesa

test: fix test condidtions

fix: zainensuzuki in ~ λ cd code/taquito

> tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach.
adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts

fix: remove type cast

* test: add tests

* refactor: remove unused constant

* fix: pr comments

* fix: pr comments

* fix: pr comments

---------

Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
zainen added a commit that referenced this pull request Mar 30, 2023
@zainen
2306 contract api sr originate (#2349)
e42a1ef 
* feat: 2306 start work on support pre local forger support

feat: continue support, need estimate fix for storageLimit and returned estimate

fix: fix test value. needs debug of storageLimit

fix: properly estimate smart rollup originate however needs better way

refactor: remove some unneeded expects

refactor: better place for storage_limit

fix: change back to update estimate provider storage limit

fix: fix any types

docs: add website docs for smart rollups

fix: fix failing test debugging expect

refactor: refactor and add test

refactor: add enum in proper place

fix: fix test not using req type

refactor: remove unneeded

refactor: fix return description

fix: add rpc method to get origination proof and modify tests and methods

docs: better wording, add slight test expect change

fix: change mumbai proto

test: add test for rpc end point

remove ,

fix: test name and missing space

fix: fix descrip

fix: consistency reqs -> params

fix: try estimation for smart rollup originate. add batch

fix: check metadata for size and apply to storage limit

docs: reword add rpc addition

test: change lima check for updated node v16 octez

test: update test for lima flextesa

test: fix test condidtions

fix: zainensuzuki in ~ λ cd code/taquito

> tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach.
adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts

fix: remove type cast

* test: add tests

* refactor: remove unused constant

* fix: pr comments

* fix: pr comments

* fix: pr comments

---------

Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
zainen added a commit that referenced this pull request Mar 30, 2023
@zainen
2306 contract api sr originate (#2349)
4507bf2 
* feat: 2306 start work on support pre local forger support

feat: continue support, need estimate fix for storageLimit and returned estimate

fix: fix test value. needs debug of storageLimit

fix: properly estimate smart rollup originate however needs better way

refactor: remove some unneeded expects

refactor: better place for storage_limit

fix: change back to update estimate provider storage limit

fix: fix any types

docs: add website docs for smart rollups

fix: fix failing test debugging expect

refactor: refactor and add test

refactor: add enum in proper place

fix: fix test not using req type

refactor: remove unneeded

refactor: fix return description

fix: add rpc method to get origination proof and modify tests and methods

docs: better wording, add slight test expect change

fix: change mumbai proto

test: add test for rpc end point

remove ,

fix: test name and missing space

fix: fix descrip

fix: consistency reqs -> params

fix: try estimation for smart rollup originate. add batch

fix: check metadata for size and apply to storage limit

docs: reword add rpc addition

test: change lima check for updated node v16 octez

test: update test for lima flextesa

test: fix test condidtions

fix: zainensuzuki in ~ λ cd code/taquito

> tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach.
adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts

fix: remove type cast

* test: add tests

* refactor: remove unused constant

* fix: pr comments

* fix: pr comments

* fix: pr comments

---------

Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
zainen added a commit that referenced this pull request Mar 30, 2023
@zainen
Revert "2306 contract api sr originate (#2349)"
185cfc5 
This reverts commit defe860.
@zainen zainen mentioned this pull request Mar 30, 2023
Merged
@zainen zainen restored the 2306-contract-api-sr-originate branch March 30, 2023 00:20
zainen added a commit that referenced this pull request Mar 30, 2023
@zainen
Revert "2306 contract api sr originate (#2349)" (#2416)
9e7c093 
This reverts commit defe860.
zainen added a commit that referenced this pull request Mar 30, 2023
@zainen
Revert "2306 contract api sr originate (#2349)"
d5dd448 
This reverts commit defe860.
zainen added a commit that referenced this pull request Mar 30, 2023
@zainen
Revert "2306 contract api sr originate (#2349)" (#2419)
d5b86e9 
This reverts commit defe860.
zainen added a commit that referenced this pull request Mar 31, 2023
@zainen
2306 contract api sr originate (#2349)
4ebf02c 
* feat: 2306 start work on support pre local forger support

feat: continue support, need estimate fix for storageLimit and returned estimate

fix: fix test value. needs debug of storageLimit

fix: properly estimate smart rollup originate however needs better way

refactor: remove some unneeded expects

refactor: better place for storage_limit

fix: change back to update estimate provider storage limit

fix: fix any types

docs: add website docs for smart rollups

fix: fix failing test debugging expect

refactor: refactor and add test

refactor: add enum in proper place

fix: fix test not using req type

refactor: remove unneeded

refactor: fix return description

fix: add rpc method to get origination proof and modify tests and methods

docs: better wording, add slight test expect change

fix: change mumbai proto

test: add test for rpc end point

remove ,

fix: test name and missing space

fix: fix descrip

fix: consistency reqs -> params

fix: try estimation for smart rollup originate. add batch

fix: check metadata for size and apply to storage limit

docs: reword add rpc addition

test: change lima check for updated node v16 octez

test: update test for lima flextesa

test: fix test condidtions

fix: zainensuzuki in ~ λ cd code/taquito

> tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach.
adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts

fix: remove type cast

* test: add tests

* refactor: remove unused constant

* fix: pr comments

* fix: pr comments

* fix: pr comments

---------

Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
zainen added a commit that referenced this pull request Mar 31, 2023
@zainen
2306 contract api sr originate (#2349)
7b6594d 
* feat: 2306 start work on support pre local forger support

feat: continue support, need estimate fix for storageLimit and returned estimate

fix: fix test value. needs debug of storageLimit

fix: properly estimate smart rollup originate however needs better way

refactor: remove some unneeded expects

refactor: better place for storage_limit

fix: change back to update estimate provider storage limit

fix: fix any types

docs: add website docs for smart rollups

fix: fix failing test debugging expect

refactor: refactor and add test

refactor: add enum in proper place

fix: fix test not using req type

refactor: remove unneeded

refactor: fix return description

fix: add rpc method to get origination proof and modify tests and methods

docs: better wording, add slight test expect change

fix: change mumbai proto

test: add test for rpc end point

remove ,

fix: test name and missing space

fix: fix descrip

fix: consistency reqs -> params

fix: try estimation for smart rollup originate. add batch

fix: check metadata for size and apply to storage limit

docs: reword add rpc addition

test: change lima check for updated node v16 octez

test: update test for lima flextesa

test: fix test condidtions

fix: zainensuzuki in ~ λ cd code/taquito

> tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach.
adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts

fix: remove type cast

* test: add tests

* refactor: remove unused constant

* fix: pr comments

* fix: pr comments

* fix: pr comments

---------

Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
dsawali pushed a commit that referenced this pull request Apr 3, 2023
@zainen
2306 contract api sr originate (#2349) (#2422)
244d642 
* 2306 contract api sr originate (#2349)

* feat: 2306 start work on support pre local forger support

feat: continue support, need estimate fix for storageLimit and returned estimate

fix: fix test value. needs debug of storageLimit

fix: properly estimate smart rollup originate however needs better way

refactor: remove some unneeded expects

refactor: better place for storage_limit

fix: change back to update estimate provider storage limit

fix: fix any types

docs: add website docs for smart rollups

fix: fix failing test debugging expect

refactor: refactor and add test

refactor: add enum in proper place

fix: fix test not using req type

refactor: remove unneeded

refactor: fix return description

fix: add rpc method to get origination proof and modify tests and methods

docs: better wording, add slight test expect change

fix: change mumbai proto

test: add test for rpc end point

remove ,

fix: test name and missing space

fix: fix descrip

fix: consistency reqs -> params

fix: try estimation for smart rollup originate. add batch

fix: check metadata for size and apply to storage limit

docs: reword add rpc addition

test: change lima check for updated node v16 octez

test: update test for lima flextesa

test: fix test condidtions

fix: zainensuzuki in ~ λ cd code/taquito

> tsc --project ./tsconfig.prod.json --module cmove logic for totalStorage into forEach.
adjust types Last login: Mon Mar 20 15:31:37 on ttys002ommonjs && rollup -c rollup.config.ts

fix: remove type cast

* test: add tests

* refactor: remove unused constant

* fix: pr comments

* fix: pr comments

* fix: pr comments

---------

Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>

* test: change test to all testnets

---------

Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
@michaelkernaghan michaelkernaghan mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsawali dsawali dsawali approved these changes

@ac10n ac10n Awaiting requested review from ac10n

@hui-an-yang hui-an-yang Awaiting requested review from hui-an-yang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mumbai] Add Smart_rollup_originate support in the Contract API
3 participants
@zainen @dsawali @hui-an-yang