Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Materialfilter PeriodOnly in ContentNode #3862

Closed
manuelmeister opened this issue Sep 29, 2023 · 0 comments · Fixed by #4366
Closed

Hide Materialfilter PeriodOnly in ContentNode #3862

manuelmeister opened this issue Sep 29, 2023 · 0 comments · Fixed by #4366

Comments

@manuelmeister
Copy link
Member

manuelmeister commented Sep 29, 2023

When editing the material for the whole camp, we have a filter on the datatable:

period-filter-useful.mp4

This filter can be useful, and we'd like to keep it.

However, when editing a single activity, the filter is also displayed in the material section:

period-filter-not-needed.mp4

In this context, displaying period materials does not work and indeed is not a useful interaction. The periodOnly filter should be removed in this view. Note: We still need the delete buttons for all of the material items, but the filter option on this column header should be removed.

MarcoAllenspach pushed a commit to MarcoAllenspach/ecamp3 that referenced this issue Dec 28, 2023
Show filter just if activity and a period material item is in the list
Add filter for activity material
MarcoAllenspach added a commit to MarcoAllenspach/ecamp3 that referenced this issue Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants