Hide Materialfilter PeriodOnly in ContentNode #4361 #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed side effects in computed property
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
manuelmeister
requested changes
Jan 1, 2024
|
@MarcoAllenspach Thanks for the PR. If you implement the changes, then this PR looks good to me and just requires another review by another eCamp core member. |
Co-authored-by: Manuel Meister <news.manuelsworld@gmail.com>
MarcoAllenspach
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
MarcoAllenspach
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
pmattmann
requested changes
Jan 3, 2024
| @@ -252,6 +258,9 @@ export default { | |||
|
|
|||
| // period Entity for displaying material items within a period (should be null if materialNode is provided) | |||
| period: { type: Object, required: false, default: null }, | |||
|
|
|||
| // Disable the filter button activity / period | |||
| disablePeriodFilter: { type: Boolean, required: false, default: false }, | |||
There was a problem hiding this comment.
This component now has an attribute disablePeriodFilter and a computed periodFilterEnabled. It took me over 5 minutes to understand why.
Counter suggestion: hidePeriodFilter says better what it does.
There was a problem hiding this comment.
You have right the naming is not really happy
I changed it to hidePeriodFilter
MarcoAllenspach
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
pmattmann
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Manuel
I hope thats not ok....Thank you for your help :)
fix #3862