chore: sync changes from api-platform template #3304
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
| @@ -34,17 +34,6 @@ | |||
| } | |||
|
|
|||
| :3001 { | |||
| # Matches requests for HTML documents, for static files, | |||
There was a problem hiding this comment.
PWA is still there in the referenced api-platform/api-platform@d059b22...7642f86
Is this only used for their admin application?
There was a problem hiding this comment.
Yes, they use it for their admin application. And it seems they also use NextJS to serve other static files.
This removed code is only the definition of the @pwa expression and doesn't change any behavior of Caddy alone. In the api-platform repo, this expression is reference further below in the reverse_proxy statement. We don't make use of this expression anywhere, so there's no reason in keeping it in our file. Unless we want to use similar expressions instead of our handle and handle_path directives. Don't know enough about Caddy though to know the difference between using request matchers and handle directives.
Follow-up from #3255