Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On delete ScheduleEntry, lock Activity #3870

Conversation

pmattmann
Copy link
Member

Locking the Activity forces a serialized delete of ScheduleEntries.

closes #2935

@BacLuc BacLuc added the deploy! Creates a feature branch deployment for this PR label Sep 30, 2023
@BacLuc BacLuc temporarily deployed to feature-branch September 30, 2023 08:23 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 30, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@BacLuc
Copy link
Contributor

BacLuc commented Sep 30, 2023

Works like a charm on the deployment.
(tested with 2 tabs open + network throttling)

@pmattmann pmattmann temporarily deployed to feature-branch September 30, 2023 10:31 — with GitHub Actions Inactive
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write unit tests like we have it for our other custom validators?

@carlobeltrame carlobeltrame force-pushed the feature/lock_activity_while_delete_schedule_entry branch from 51d351e to 01ba54f Compare October 21, 2023 17:13
@carlobeltrame carlobeltrame temporarily deployed to feature-branch October 21, 2023 17:30 — with GitHub Actions Inactive
api/translations/validators.fr.yml Outdated Show resolved Hide resolved
@carlobeltrame carlobeltrame temporarily deployed to feature-branch October 21, 2023 20:58 — with GitHub Actions Inactive
@carlobeltrame carlobeltrame temporarily deployed to feature-branch October 21, 2023 21:24 — with GitHub Actions Inactive
@pmattmann pmattmann added this pull request to the merge queue Oct 22, 2023
Merged via the queue into ecamp:devel with commit adf2452 Oct 22, 2023
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent deleting the last two schedule entries of an activity at the same time
3 participants