-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On delete ScheduleEntry, lock Activity #3870
Merged
pmattmann
merged 9 commits into
ecamp:devel
from
pmattmann:feature/lock_activity_while_delete_schedule_entry
Oct 22, 2023
Merged
On delete ScheduleEntry, lock Activity #3870
pmattmann
merged 9 commits into
ecamp:devel
from
pmattmann:feature/lock_activity_while_delete_schedule_entry
Oct 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
approved these changes
Sep 30, 2023
BacLuc
temporarily deployed
to
feature-branch
September 30, 2023 08:23
— with
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
Works like a charm on the deployment. |
pmattmann
temporarily deployed
to
feature-branch
September 30, 2023 10:31
— with
GitHub Actions
Inactive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write unit tests like we have it for our other custom validators?
Allows a proper each Activity must have a ScheduleEntry check
carlobeltrame
force-pushed
the
feature/lock_activity_while_delete_schedule_entry
branch
from
October 21, 2023 17:13
51d351e
to
01ba54f
Compare
carlobeltrame
approved these changes
Oct 21, 2023
carlobeltrame
temporarily deployed
to
feature-branch
October 21, 2023 17:30
— with
GitHub Actions
Inactive
BacLuc
approved these changes
Oct 21, 2023
carlobeltrame
temporarily deployed
to
feature-branch
October 21, 2023 20:58
— with
GitHub Actions
Inactive
carlobeltrame
temporarily deployed
to
feature-branch
October 21, 2023 21:24
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locking the Activity forces a serialized delete of ScheduleEntries.
closes #2935