Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: variant has been renamed to isDefaultVariant #3962

Conversation

manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Oct 14, 2023

Bug was introduced in #3894

Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used to differentiate between mobile and desktop layout, right?
If so, isDesktopLayout would probably be a better self-speaking name that isDefaultVariant.

@manuelmeister
Copy link
Member Author

@usu no, it is used to display different variants based on the actual content width (e.g. with multiple columns on desktop). Otherwise I would have used css breakpoints.

@manuelmeister manuelmeister added this pull request to the merge queue Oct 20, 2023
Merged via the queue into ecamp:devel with commit 3ebcabc Oct 20, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants