Optimize material table in small container #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
manuelmeister
added
deploy!
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
DeNic0la
reviewed
Oct 1, 2023
There was a problem hiding this comment.
For the most part, this is a simple change away from the $vuetify.breakpoint to use the clientWidth <= 710 as a check.
variant is a string representation of that check.
I am assuming clientWidth is the with of the component rather than the entire window, which would be nice but maybe I misunderstood something.
|
@DeNic0la clientWidth is the width of the element. |
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
DeNic0la
approved these changes
Oct 1, 2023
pmattmann
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically use the dense version of the MaterialTable if not enough space is available for default table mode instead of list mode.
Same code as in Storyboard.vue