-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize column layout experience #4006
Optimize column layout experience #4006
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed to keep print as is for now. Adding too many nested narrow columns is discouraged by this PR, and people should gravitate naturally towards not using too many nested columns.
<ContentLayout | ||
v-resizeobserver.debounce="onResize" | ||
class="ec-column-layout" | ||
:class="{ 'ec-column-layout--layout-mode my-2': !isRoot && layoutMode }" | ||
:is-root="isRoot" | ||
:layout-mode="layoutMode" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the styling inside this component? It already has all the information it needs, and part of the styles are already done there.
Also the style doesn't quite match vuetify's material design. Can you change it to match the existing design style we have everywhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will get reused in flex layout. I agree that the design is not consistent with Material Design and that it could be improved.
I opted for this design, as it is clearly different from the non-layout content types while still being compact. If you have a good idea how we could design this, I would like your input in a followup issue.
This is a prework for #3966