Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize column layout experience #4006

Merged
merged 10 commits into from
Oct 22, 2023

Conversation

manuelmeister
Copy link
Member

  • ColumnLayout wraps based on content width instead of viewport width
  • ContentNodes grow to their full potential inside the column ;)
  • Moved column operations to ContentLayout header

This is a prework for #3966

@manuelmeister manuelmeister added UX/UI deploy! Creates a feature branch deployment for this PR labels Oct 21, 2023
@manuelmeister manuelmeister temporarily deployed to feature-branch October 21, 2023 21:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 21, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to keep print as is for now. Adding too many nested narrow columns is discouraged by this PR, and people should gravitate naturally towards not using too many nested columns.

frontend/src/components/activity/DraggableContentNodes.vue Outdated Show resolved Hide resolved
Comment on lines 2 to 8
<ContentLayout
v-resizeobserver.debounce="onResize"
class="ec-column-layout"
:class="{ 'ec-column-layout--layout-mode my-2': !isRoot && layoutMode }"
:is-root="isRoot"
:layout-mode="layoutMode"
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the styling inside this component? It already has all the information it needs, and part of the styles are already done there.
Also the style doesn't quite match vuetify's material design. Can you change it to match the existing design style we have everywhere else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will get reused in flex layout. I agree that the design is not consistent with Material Design and that it could be improved.
I opted for this design, as it is clearly different from the non-layout content types while still being compact. If you have a good idea how we could design this, I would like your input in a followup issue.

frontend/src/components/activity/content/ColumnLayout.vue Outdated Show resolved Hide resolved
@manuelmeister manuelmeister temporarily deployed to feature-branch October 22, 2023 12:24 — with GitHub Actions Inactive
@manuelmeister manuelmeister temporarily deployed to feature-branch October 22, 2023 12:51 — with GitHub Actions Inactive
@manuelmeister manuelmeister added this pull request to the merge queue Oct 22, 2023
Merged via the queue into ecamp:devel with commit e12da72 Oct 22, 2023
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR UX/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants