Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New FlexLayout for improved content layouting #3966

Conversation

manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Oct 14, 2023

This pull request introduces an enhanced FlexLayout with minimized configurability for better automatic positioning of aside elements in constrained spaces.

The ColumnLayout has also been updated to ensure accurate border rendering in conjunction with the new fluid layout design.

Note

The black borders around the layout nodes are still a work in progress. Feedback is particularly sought on the layout mechanism and its overall functionality, rather than visual aesthetics or code linting.

Bildschirmfoto 2023-10-15 um 00 44 36

Bildschirmfoto 2023-10-15 um 00 44 58

Bildschirmfoto 2023-10-15 um 00 45 13

Bildschirmfoto 2023-10-15 um 00 45 38

@manuelmeister manuelmeister added type: Frontend UX/UI deploy! Creates a feature branch deployment for this PR Needs prototype Please make a prototype (code, mockup, sketch, etc.) first labels Oct 14, 2023
@manuelmeister manuelmeister changed the title New FlexLayout for Improved Content lLayouting New FlexLayout for improved content layouting Oct 14, 2023
@manuelmeister manuelmeister temporarily deployed to feature-branch October 14, 2023 22:32 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 14, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@manuelmeister manuelmeister temporarily deployed to feature-branch October 14, 2023 23:23 — with GitHub Actions Inactive
@carlobeltrame
Copy link
Member

Haven't tried or reviewed yet. But flexbox is not a term which our users will understand, and given that the users have less control, it will feel less flexible to themthan the column layout. How about renaming it to intelligent layout or magic layout?

@manuelmeister
Copy link
Member Author

Okay for me, but I tought less about actual flexbox and more about flexible as in it adapts based on the width.

In the future it could be possible to have a single flexible column where the items just wrap, or a triple column, and so on…
That's why i called it FlexLayout in the Backend and "Automatic Layout" in the frontend.

Currently it was just easier to implement two columns only, as this has the most basic functionality.

@manuelmeister manuelmeister temporarily deployed to feature-branch October 21, 2023 20:30 — with GitHub Actions Inactive
@manuelmeister
Copy link
Member Author

manuelmeister commented Oct 21, 2023

Core Meeting Decision

Split PR into own subparts

@manuelmeister
Copy link
Member Author

Superceded by #3522, #4026 & #4071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR Needs prototype Please make a prototype (code, mockup, sketch, etc.) first type: Frontend UX/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants