Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement paper and widescreen display size for activity #4026

Merged
merged 5 commits into from Nov 10, 2023
Merged

Implement paper and widescreen display size for activity #4026

merged 5 commits into from Nov 10, 2023

Conversation

manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Oct 24, 2023 •
edited

With this feature it could suggest how the layout looks like in print. The value is stored in the localStorage.

Bildschirmfoto 2023-10-24 um 20 56 52
Bildschirmfoto 2023-10-24 um 20 56 57

@manuelmeister manuelmeister added type: Frontend UX/UI deploy! Creates a feature branch deployment for this PR labels Oct 24, 2023
@manuelmeister manuelmeister temporarily deployed to feature-branch October 24, 2023 19:03 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@manuelmeister manuelmeister temporarily deployed to feature-branch October 24, 2023 19:06 — with GitHub Actions Inactive
BacLuc
BacLuc reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few minor comments

frontend/src/components/activity/ScheduleEntry.vue Outdated Show resolved Hide resolved
frontend/src/components/activity/ScheduleEntry.vue Outdated Show resolved Hide resolved
frontend/src/components/activity/ScheduleEntry.vue Show resolved Hide resolved
@manuelmeister manuelmeister temporarily deployed to feature-branch October 27, 2023 11:41 — with GitHub Actions Inactive
@manuelmeister manuelmeister temporarily deployed to feature-branch October 27, 2023 11:56 — with GitHub Actions Inactive
@manuelmeister manuelmeister added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@manuelmeister manuelmeister added this pull request to the merge queue Nov 10, 2023
Merged via the queue into ecamp:devel with commit 4634a31 Nov 10, 2023
28 checks passed
@manuelmeister manuelmeister deleted the feature/papersize branch November 11, 2023 10:30
@BacLuc BacLuc mentioned this pull request Dec 5, 2023
Merged
@manuelmeister manuelmeister mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmattmann pmattmann pmattmann approved these changes

@BacLuc BacLuc BacLuc approved these changes

@usu usu Awaiting requested review from usu

@carlobeltrame carlobeltrame Awaiting requested review from carlobeltrame

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR type: Frontend UX/UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manuelmeister @pmattmann @BacLuc