Be able to edit scheduleEntries from activity and to edit activityResponsibles #4375
Conversation
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
manuelmeister
added
UX/UI
External feedback
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
|
@carlobeltrame moved it to the right side. |
| </tbody> | ||
| </table> | ||
| <DialogActivityEdit | ||
| v-if="activity" |
There was a problem hiding this comment.
you should hide or disable the button for guests. (if the activity is not editable)
| if (!this.hideHeaderFields) { | ||
| const untouchedActivityResponsibles = intersectionWith( | ||
| this.initialResponsibles, | ||
| this.entityData.activityResponsibles, | ||
| (a, b) => { | ||
| return a.campCollaboration._meta.self === b.campCollaboration._meta.self | ||
| } | ||
| ) | ||
|
|
||
| const differentActivityResponsibles = differenceWith( | ||
| [...this.initialResponsibles, ...this.entityData.activityResponsibles], | ||
| untouchedActivityResponsibles, | ||
| (a, b) => { | ||
| return a.campCollaboration._meta.self === b.campCollaboration._meta.self | ||
| } | ||
| ) | ||
|
|
||
| differentActivityResponsibles.forEach((activityResponsible) => { | ||
| if (activityResponsible?._meta?.self) { | ||
| promises.push(this.api.del(activityResponsible._meta.self)) | ||
| } else { | ||
| promises.push( | ||
| this.activityResponsibles.$post({ | ||
| activity: this.currentActivity._meta.self, | ||
| campCollaboration: activityResponsible.campCollaboration._meta.self, | ||
| }) | ||
| ) | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
I think this is solved little to simple. (even though i see a lot of thought process)
- This should not be in the update logic of the scheduleEntries
- In this function all the promises to update things (scheduleEntries, the activity itself) are collected and awaited. This should be preserved.
I would split the 2 changes in separate PR and first add the possibility to edit the scheduleEntries in the Activity View.
And then add the responsibles to the activty dialog in the picasso.
There was a problem hiding this comment.
@BacLuc "too simple"? What should I make more complicated/different?
- This should not be in the update logic of the scheduleEntries
Why?
- … This should be preserved.
It is, it just adds the update scheduleEntries to the same promises array as scheduleEntries and activity.
There was a problem hiding this comment.
@BacLuc "too simple"? What should I make more complicated/different?
- This should not be in the update logic of the scheduleEntries
Why?
But you don't want to send the post/delete requests for the activityResponsibles for each ScheduleEntry.
(The delete and posts for the same insertion/deletion are sent for each scheduleEntry once as i read the code).
- … This should be preserved.
It is, it just adds the update scheduleEntries to the same promises array as scheduleEntries and activity.
but something seems to not work:
Screencast from 07.01.2024 14:24:44.webm
There was a problem hiding this comment.
uups, sorry.
Its not in the update for the scheduleentries.
|
@BacLuc hmm, do you know why this was not merged? |
I don't know it, but i vaguely remember that this was at the time we switched to api-platform. |
It makes sense to be able to edit the activity properties from the activity view.
(I thought it might be better to also be able to also be able to edit the title and category, to help people that did not get the trick to click on the title / category to change it.)
Also it makes sense to be able to edit the activity responsibles in the edit dialog.
This is restricted to the edit dialog and is not implemented for the creation dialog.