feat: Edit schedule entries from activity view #4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
…ule-entries-on-activity # Conflicts: # frontend/src/components/activity/ScheduleEntry.vue
manuelmeister
changed the title
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
BacLuc
reviewed
Jan 19, 2024
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
BacLuc
approved these changes
Jan 20, 2024
usu
requested changes
Jan 31, 2024
| @@ -35,11 +37,13 @@ | |||
| </e-select> | |||
|
|
|||
| <e-text-field | |||
| v-if="!hideLocation" | |||
There was a problem hiding this comment.
For me also worth a discussion, if we want to remove location completely from this form.
frontend/src/components/activity/dialog/FormScheduleEntryItem.vue
Outdated
Show resolved
Hide resolved
|
Waiting on #4746 |
…re/edit-schedule-entries-on-activity # Conflicts: # common/locales/de.json # common/locales/en.json # common/locales/fr.json # common/locales/it.json # frontend/src/components/activity/ScheduleEntry.vue # frontend/src/components/activity/dialog/DialogActivityForm.vue # frontend/src/components/activity/dialog/FormScheduleEntryItem.vue # frontend/src/components/program/ScheduleEntries.vue # frontend/src/components/program/picasso/PicassoEntry.vue # frontend/src/locales/fr.json
Merged
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
usu
approved these changes
Apr 14, 2024
BacLuc
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes sense to be able to edit the activity properties from the activity view:
It opens the EditActivityDialog and hides fields already present in the activity header.
(I thought it is better to also be able to edit the title and category, to help people that did not get the trick to click on the title / category to change it.)
This only adds the edit button of #4375, but does not implement the activity responsibles as requested by @BacLuc
Fixes #1375