-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3499 #4405
Fix #3499 #4405
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to remove the tooltip and just use the hint instead if readonlyRole
is true, else we omit the hint.
@manuelmeister I don't think this is better because the user can press the button and don't know why it doesn't works if he don't read carefully... |
@manuelmeister see my last comment |
@MarcoAllenspach Regarding the tooltip on the button, I suggest keeping it. Apologies for any confusion caused by my previous response. |
If @MarcoAllenspach or someone else wants to continue, they are free to reopen it. |
4a549ea
to
f73ced3
Compare
f73ced3
to
bea5a22
Compare
@manuelmeister So its like in my picture on the comment from January 9te? Or do i understand it wrong? |
fixed #3499
Remove sentence but not hint