Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team: Remove role min required admins in readonly & creation mode #3499

Closed
2 tasks
Tracked by #3498
manuelmeister opened this issue Jun 5, 2023 · 2 comments · Fixed by #4405
Closed
2 tasks
Tracked by #3498

Team: Remove role min required admins in readonly & creation mode #3499

manuelmeister opened this issue Jun 5, 2023 · 2 comments · Fixed by #4405

Comments

@manuelmeister
Copy link
Member

manuelmeister commented Jun 5, 2023

#3348 (comment)
On the teams page (https://dev.ecamp3.ch/camps/6973c230d6b1/Harry-Potter-Lager/collaborators)

Let it be in the edit mode, as it is good to know general requirements.

TODO:

  • Remove the hint that at least one manager must remain in the camp below the role dropdown in the create and in the edit dialog. (This may be the same code)
  • The hint is still displayed as a tooltip when the user tries to change the role of the last manager.
@carlobeltrame
Copy link
Member

If it's easier, it can also be removed from edit view. We have the tooltip which shows this exact message again when it's really relevant. It's not really a surprising rule, and users can easily figure out how to work around it as soon as they see the explanation.

@MarcoAllenspach
Copy link
Contributor

Is it correct that just this:
image
this sentence must be removed (on invite people and edit people)

I will do it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants