Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty submit in activity title #4610

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix empty submit in activity title #4610

merged 1 commit into from
May 22, 2024

Conversation

carlobeltrame
Copy link
Member

Attempt to fix a bug when editing the activity name and pressing ENTER to submit without changes.
Before:
Screencast from 02-03-2024 10:56:07 PM.webm

After:
Screencast from 02-03-2024 11:01:15 PM.webm

However, I am unsure whether this will break something else. Any ideas?

@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label Feb 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@manuelmeister manuelmeister added the test-flaky-e2e! Add this label to a PR to run e2e tests multiple times label Feb 4, 2024
manuelmeister
manuelmeister reviewed Feb 4, 2024
View reviewed changes
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what all depends on the execution order.

@BacLuc BacLuc removed the deploy! Creates a feature branch deployment for this PR label Feb 18, 2024
BacLuc
BacLuc approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It improves the behaviour.
I don't understand why, but that is ok

@carlobeltrame
Copy link
Member Author

I'd say we merge it and if it causes problems which we can't handle, it's easy to revert.

@carlobeltrame carlobeltrame added this pull request to the merge queue May 22, 2024
Merged via the queue into ecamp:devel with commit 809e7aa May 22, 2024
104 checks passed
@BacLuc BacLuc mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelmeister manuelmeister manuelmeister left review comments

@pmattmann pmattmann pmattmann approved these changes

@BacLuc BacLuc BacLuc approved these changes

@usu usu Awaiting requested review from usu

Assignees
No one assigned
Labels
test-flaky-e2e! Add this label to a PR to run e2e tests multiple times
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlobeltrame @pmattmann @BacLuc @manuelmeister